Skip to content

[CI] Use clang-format from nightly builds #5126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 12, 2021

Conversation

alexbatashev
Copy link
Contributor

@alexbatashev alexbatashev commented Dec 11, 2021

Contributing guide suggests using the same version of clang-format, that is build from tip of this repository. That caused problems in the past, where the newer clang-format does the job differently to what's being used in CI. This patch switches to default clang-format installation to the one, that comes with nightly builds. This would allow us to minimize the impact of different clang-format versions.

@alexbatashev alexbatashev marked this pull request as ready for review December 11, 2021 13:37
@alexbatashev alexbatashev requested a review from bader as a code owner December 11, 2021 13:37
@bader bader merged commit d3649d8 into intel:sycl Dec 12, 2021
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Dec 14, 2021
* sycl:
  [CI] Refactor workflow files (intel#5134)
  [CI] Enable HIP and CUDA plugins in GitHub Actions builds (intel#5087)
  [SYCL] Implement queue flushing (intel#5052)
  [SYCL] Allow library mismatch for libdevice host object on Win32 (intel#5048)
  [SYCL] Remove unnecessary template parameter (intel#5127)
  [CI] Use clang-format from nightly builds (intel#5126)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants