[SYCL] Fix kernel bundles don't really carry kernel IDs #5121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR with test |
smaslov-intel
approved these changes
Dec 15, 2021
steffenlarsen
approved these changes
Dec 15, 2021
v-klochkov
approved these changes
Dec 15, 2021
|
@denis-kabanov, please, fix pre-commit test failures for intel/llvm-test-suite#616. |
@bader, according to verify with #5121, my test passed all checks, whereas failed tests (Assert, DeviceLib) are a common problem for each pr to llvm-test-suite. |
|
@denis-kabanov, @intel/llvm-reviewers-runtime, I would like patches to pass all tests in pre-commit. Please, address common problems first. If it takes time, we can disable failing tests while working on them. |
denis-kabanov
added a commit
to denis-kabanov/llvm-test-suite
that referenced
this pull request
Dec 21, 2021
Disable Basic/get_backend test due to sporadic failures in prs: intel/llvm#5191 intel/llvm#5121
|
A failed test is irrelevant to these changes. |
Check for carrying real kernel IDs passed Jenkins/llvm-test-suite. |
bader
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Dec 22, 2021
Disable Basic/get_backend test due to sporadic failures in prs: intel/llvm#5191 intel/llvm#5121
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Dec 23, 2021
* upstream/sycl: (1382 commits) [SYCL][XPTI] Report memory allocation info from SYCL runtime (intel#5172) [CI] Switch labels for OCL x64 job (intel#5185) [SYCL] Add basic support for the generic_space address space (intel#5148) [CI] Update CODEOWNERS for SYCL printf support passes (intel#5199) [SYCL][Matrix] Enable wi_slice for joint_matrix (intel#4979) [SYCL][Group algorithms] Move group sort extension to experimental (intel#5169) [SYCL] Fix kernel bundles don't really carry kernel IDs (intel#5121) [SYCL] Initial printf support for non-constant AS format strings (intel#5069) [SYCL][NFC] Fix static code analysis concerns (intel#5189) [SYCL][Doc] Fix typos to fix doc build (intel#5190) [Driver][SYCL] Turn on -fsycl-dead-args-optimization by default (intel#3004) [SYCL][L0][Plugin] Add support for batching copy commands (intel#5155) [CI] Add cache checkout script to docker containers (intel#5184) [SYCL][Doc] Add HIP backend to the filter selector (intel#5176) [Doc] Add documentation for Docker images (intel#4778) [LIBCLC] Add functionality for in-kernel asserts for CUDA backend (intel#5174) Force opt to use new pass manager in exponential-deferred-inlining test after a8c2ba1 [SYCL] Add vec and marray support to known_identity type trait (intel#5163) Correctly resolve merge conflicts Update SPV_INTEL_hw_thread_queries to rev 2 ...
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
Disable Basic/get_backend test due to sporadic failures in prs: intel#5191 intel#5121
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix that interop kernel bundles don't really carry kernel IDs for contained kernels. This change adds In enqueueImpKernel another condition to taking the path using the associated kernel_bundle, namely that interop bundles can't be used in the first branch. (This is because the kernels in interop kernel bundles (if any) do not have kernel_id and can therefore not be looked up, but since they are self-contained they can simply be launched directly.)