[CI] Add container users to video group #5101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bader
reviewed
Dec 9, 2021
| @@ -9,6 +9,9 @@ on: | |||
| - sycl | |||
| paths: | |||
| - 'devops/containers/**' | |||
| pull_request: | |||
| paths: | |||
| - 'devops/containers/**' | |||
|
|
|||
| jobs: | |||
| base_image_ubuntu2004: | |||
There was a problem hiding this comment.
All three jobs are the same - the only difference is the container name. Can we avoid duplication by applying re-usable workflows or matrix strategy here?
There was a problem hiding this comment.
This is probably as far as I can go simplifying this file. Matrix builds do not support dependencies, and re-usable workflows would still require me to pass input parameters, which would be identical to what I did with actions.
There was a problem hiding this comment.
I was aiming to avoid duplication of "push: ${{ github.event_name != 'pull_request' }}" condition.
bader
approved these changes
Dec 11, 2021
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Dec 12, 2021
* upstream/sycl: [CI] Add container users to video group (intel#5101) [CI] More typo fixes in Nightly build (intel#5088) Revert "[CI] Disable pack and upload steps (intel#5119)" (intel#5125) [SYCL] Translate ZE_RESULT_ERROR_INVALID_ARGUMENT error code from L0 RT (intel#5122) [SYCL][L0][Plugin] Call ZeCommandQueueCreate on demand (intel#5109) [SYCL] Switch to using blocking USM free for OpenCL GPU (intel#4928) [CI] Disable pack and upload steps (intel#5119) [SYCL] Disable submission of AssertInfoCopier for FPGA (intel#4780) [SYCL][SPIRV] Implement islessgreater with FOrdNotEqual instead (intel#5076) [SYCL] Fix typo in the name of the host-visible pool (intel#5073) [SYCL] Only call shutdown when DLL is being unloaded, not when process is terminating (intel#4983) [SYCL][CUDA][PI] Fix infinite loop when parallel_for range exceeds INT_MAX (intel#5095) [SYCL] Translate out-of-memory error codes from L0 RT (intel#5107) [SYCL] Fix a few warnings during build scripts configuration (intel#5082) [SYCL] Fix amdgpu openmp test (intel#5103) [SYCL] [FPGA] Create experimental headers for FPGA latency control (intel#5066) [SYCL][CUDA] Don't enqueue an event wait on same CUDA stream (intel#5099) Remove PR disable template (intel#5102) [BuildBot]Uplift CPU/FPGAEMU RT version (intel#5078)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing
/dev/dridevice (GPU) requires user to be invideogroup. Change containers to includesycluser into the group.Also change workflow to build containers in pre-commit without pushing to the registry to make sure containers are still buildable.