Skip to content

[SYCL] Fix a few warnings during build scripts configuration #5082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

denis-kabanov
Copy link
Contributor

No description provided.

vladimirlaz
vladimirlaz previously approved these changes Dec 3, 2021
Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the goal of this patch to make CMake configuration step free from warnings?
If so, we need to fix this warning:

CMake Warning (dev) in /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/libclc/CMakeLists.txt:
  A logical block opening on the line
    /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/libclc/CMakeLists.txt:86 (if)
  closes on the line
    /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/libclc/CMakeLists.txt:88 (endif)

Tagging code author for awareness - @Naghasan.

@AlexeySotkin, @AlexeySachkov, please, help with disabling SPIR-V translator project related warnings:

CMake Warning at /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/llvm-spirv/test/CMakeLists.txt:32 (message):
  spirv-as not found! SPIR-V assembly tests will not be run.
CMake Warning at /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/llvm-spirv/test/CMakeLists.txt:37 (message):
  spirv-link not found! SPIR-V test involving the linker will not be run.
CMake Warning at /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/llvm-spirv/test/CMakeLists.txt:42 (message):
  spirv-val not found! SPIR-V generated for test suite will not be validated.

Copy link
Contributor

@bader bader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found one more warning on Windows:

-- Performing Test HAVE_POSIX_REGEX -- failed to compile
CMake Warning at utils/benchmark/CMakeLists.txt:248 (message):
  Using std::regex with exceptions disabled is not fully supported

@denis-kabanov
Copy link
Contributor Author

I found one more warning on Windows:

-- Performing Test HAVE_POSIX_REGEX -- failed to compile
CMake Warning at utils/benchmark/CMakeLists.txt:248 (message):
  Using std::regex with exceptions disabled is not fully supported

This warning is related to benchmark tests, so we need to turn on BENCHMARK_ENABLE_EXCEPTIONS to fix it, but how does this affect the performance of such tests?
OR I can just suppress it.
@bader what do you think will be better?

@bader
Copy link
Contributor

bader commented Dec 6, 2021

From the offline discussion, I got an impression that your goal is not fix all the warnings. AFAIK, DPC++ doesn't use "benchmark test", so I don't think we should fix this warning.

@Naghasan
Copy link
Contributor

Naghasan commented Dec 6, 2021

If so, we need to fix this warning:

CMake Warning (dev) in /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/libclc/CMakeLists.txt:
  A logical block opening on the line
    /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/libclc/CMakeLists.txt:86 (if)
  closes on the line
    /localdisk2/sycl_ci/buildbot/worker/Lit_With_Cuda/llvm.src/libclc/CMakeLists.txt:88 (endif)
Tagging code author for awareness - @Naghasan.

Thanks for the fix :)

@denis-kabanov
Copy link
Contributor Author

I think that warnings about spirv is quite important, so they should remain.

@bader
Copy link
Contributor

bader commented Dec 8, 2021

I think that warnings about spirv is quite important, so they should remain.

I don't think emitting warnings is a good choice for missing tools notification, I think STATUS fits better, but translator issues shouldn't be fixed in this repository anyway.

@bader bader changed the title [SYCL]Small fix for warnings during configuration [SYCL] Fix a few warnings during build scripts configuration Dec 8, 2021
@Naghasan
Copy link
Contributor

Naghasan commented Dec 8, 2021

I don't think emitting warnings is a good choice for missing tools notification

my 2 cents: part of the testing depends on these tools, so I think warning is the appropriate choice.

@bader bader merged commit 8458fab into intel:sycl Dec 8, 2021
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Dec 11, 2021
* upstream/sycl: (725 commits)
  [SYCL] Translate ZE_RESULT_ERROR_INVALID_ARGUMENT error code from L0 RT (intel#5122)
  [SYCL][L0][Plugin] Call ZeCommandQueueCreate on demand (intel#5109)
  [SYCL] Switch to using blocking USM free for OpenCL GPU (intel#4928)
  [CI] Disable pack and upload steps (intel#5119)
  [SYCL] Disable submission of AssertInfoCopier for FPGA (intel#4780)
  [SYCL][SPIRV] Implement islessgreater with FOrdNotEqual instead (intel#5076)
  [SYCL] Fix typo in the name of the host-visible pool (intel#5073)
  [SYCL] Only call shutdown when DLL is being unloaded, not when process is terminating (intel#4983)
  [SYCL][CUDA][PI] Fix infinite loop when parallel_for range exceeds INT_MAX (intel#5095)
  [SYCL] Translate out-of-memory error codes from L0 RT (intel#5107)
  [SYCL] Fix a few warnings during build scripts configuration (intel#5082)
  [SYCL] Fix amdgpu openmp test (intel#5103)
  [SYCL] [FPGA] Create experimental headers for FPGA latency control (intel#5066)
  [SYCL][CUDA] Don't enqueue an event wait on same CUDA stream (intel#5099)
  Remove PR disable template (intel#5102)
  [BuildBot]Uplift CPU/FPGAEMU RT version (intel#5078)
  [SYCL] Fix the test to not depend on a specific line. (intel#5092)
  [CI] Provide libclc targets to build and test (intel#5091)
  Fix build of `check-llvm-spirv` target after 8f8001a
  Force opt to use new pass manager in pr52289 test after c34d157
  ...
alexbatashev added a commit to alexbatashev/llvm that referenced this pull request Dec 12, 2021
* upstream/sycl:
  [CI] Add container users to video group (intel#5101)
  [CI] More typo fixes in Nightly build (intel#5088)
  Revert "[CI] Disable pack and upload steps (intel#5119)" (intel#5125)
  [SYCL] Translate ZE_RESULT_ERROR_INVALID_ARGUMENT error code from L0 RT (intel#5122)
  [SYCL][L0][Plugin] Call ZeCommandQueueCreate on demand (intel#5109)
  [SYCL] Switch to using blocking USM free for OpenCL GPU (intel#4928)
  [CI] Disable pack and upload steps (intel#5119)
  [SYCL] Disable submission of AssertInfoCopier for FPGA (intel#4780)
  [SYCL][SPIRV] Implement islessgreater with FOrdNotEqual instead (intel#5076)
  [SYCL] Fix typo in the name of the host-visible pool (intel#5073)
  [SYCL] Only call shutdown when DLL is being unloaded, not when process is terminating (intel#4983)
  [SYCL][CUDA][PI] Fix infinite loop when parallel_for range exceeds INT_MAX (intel#5095)
  [SYCL] Translate out-of-memory error codes from L0 RT (intel#5107)
  [SYCL] Fix a few warnings during build scripts configuration (intel#5082)
  [SYCL] Fix amdgpu openmp test (intel#5103)
  [SYCL] [FPGA] Create experimental headers for FPGA latency control (intel#5066)
  [SYCL][CUDA] Don't enqueue an event wait on same CUDA stream (intel#5099)
  Remove PR disable template (intel#5102)
  [BuildBot]Uplift CPU/FPGAEMU RT version (intel#5078)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants