[SYCL][SPIRV] Implement islessgreater with FOrdNotEqual instead #5076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SPIR-V OpLessOrGreater is deprecated: https://www.khronos.org/registry/SPIR-V/specs/unified1/SPIRV.html#OpLessOrGreater OpFOrdNotEqual has the same semantics as OpLessOrGreater.
Could @bader please approve running workflows? Many thanks! |
Signed-off-by: Yilong Guo <yilong.guo@intel.com>
Signed-off-by: Yilong Guo <yilong.guo@intel.com>
bader
requested changes
Dec 3, 2021
| // (LessOrGreater) // islessgreater | ||
| __SYCL_EXPORT s::cl_int LessOrGreater(s::cl_float x, s::cl_float y) __NOEXC { | ||
| return __sLessOrGreater(x, y); | ||
| // (FOrdNotEqual) // islessgreater |
There was a problem hiding this comment.
@Nuullll, please, follow Contribution guide and pay attention to ABI policies in particular.
I think we can't remove LessOrGreater immediately and should rather deprecate them first.
There was a problem hiding this comment.
Thanks @bader. That makes sense since this is an ABI-breaking change.
Then may I ask how to deprecate an ABI?
There was a problem hiding this comment.
how to deprecate an ABI?
@romanovvlad, @s-kanaev, please, add an answer to this question to ABI Policy Guide.
bader
requested review from
a team and
dm-vodopyanov
and removed request for
a team
Nuullll
changed the title
Nuullll
changed the title
|
@Nuullll, are you still working on it? Or just just forgot to push "Ready for review" button? |
Nuullll
changed the title
Thanks for reminding. Please help review it :-P |
bader
approved these changes
Dec 7, 2021
ping #2. |
dm-vodopyanov
approved these changes
Dec 9, 2021
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Dec 11, 2021
* upstream/sycl: (725 commits) [SYCL] Translate ZE_RESULT_ERROR_INVALID_ARGUMENT error code from L0 RT (intel#5122) [SYCL][L0][Plugin] Call ZeCommandQueueCreate on demand (intel#5109) [SYCL] Switch to using blocking USM free for OpenCL GPU (intel#4928) [CI] Disable pack and upload steps (intel#5119) [SYCL] Disable submission of AssertInfoCopier for FPGA (intel#4780) [SYCL][SPIRV] Implement islessgreater with FOrdNotEqual instead (intel#5076) [SYCL] Fix typo in the name of the host-visible pool (intel#5073) [SYCL] Only call shutdown when DLL is being unloaded, not when process is terminating (intel#4983) [SYCL][CUDA][PI] Fix infinite loop when parallel_for range exceeds INT_MAX (intel#5095) [SYCL] Translate out-of-memory error codes from L0 RT (intel#5107) [SYCL] Fix a few warnings during build scripts configuration (intel#5082) [SYCL] Fix amdgpu openmp test (intel#5103) [SYCL] [FPGA] Create experimental headers for FPGA latency control (intel#5066) [SYCL][CUDA] Don't enqueue an event wait on same CUDA stream (intel#5099) Remove PR disable template (intel#5102) [BuildBot]Uplift CPU/FPGAEMU RT version (intel#5078) [SYCL] Fix the test to not depend on a specific line. (intel#5092) [CI] Provide libclc targets to build and test (intel#5091) Fix build of `check-llvm-spirv` target after 8f8001a Force opt to use new pass manager in pr52289 test after c34d157 ...
alexbatashev
added a commit
to alexbatashev/llvm
that referenced
this pull request
Dec 12, 2021
* upstream/sycl: [CI] Add container users to video group (intel#5101) [CI] More typo fixes in Nightly build (intel#5088) Revert "[CI] Disable pack and upload steps (intel#5119)" (intel#5125) [SYCL] Translate ZE_RESULT_ERROR_INVALID_ARGUMENT error code from L0 RT (intel#5122) [SYCL][L0][Plugin] Call ZeCommandQueueCreate on demand (intel#5109) [SYCL] Switch to using blocking USM free for OpenCL GPU (intel#4928) [CI] Disable pack and upload steps (intel#5119) [SYCL] Disable submission of AssertInfoCopier for FPGA (intel#4780) [SYCL][SPIRV] Implement islessgreater with FOrdNotEqual instead (intel#5076) [SYCL] Fix typo in the name of the host-visible pool (intel#5073) [SYCL] Only call shutdown when DLL is being unloaded, not when process is terminating (intel#4983) [SYCL][CUDA][PI] Fix infinite loop when parallel_for range exceeds INT_MAX (intel#5095) [SYCL] Translate out-of-memory error codes from L0 RT (intel#5107) [SYCL] Fix a few warnings during build scripts configuration (intel#5082) [SYCL] Fix amdgpu openmp test (intel#5103) [SYCL] [FPGA] Create experimental headers for FPGA latency control (intel#5066) [SYCL][CUDA] Don't enqueue an event wait on same CUDA stream (intel#5099) Remove PR disable template (intel#5102) [BuildBot]Uplift CPU/FPGAEMU RT version (intel#5078)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPIR-V OpLessOrGreater is deprecated:
https://www.khronos.org/registry/SPIR-V/specs/unified1/SPIRV.html#OpLessOrGreater
OpFOrdNotEqual has the same semantics as OpLessOrGreater.
Signed-off-by: Yilong Guo yilong.guo@intel.com