Renaming esimd emu from esimd cpu #4728
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongkyunahn-intel
requested review from
againull,
kychendev,
smaslov-intel,
v-klochkov and
a team
as code owners
againull
previously approved these changes
Oct 7, 2021
kbobrovs
reviewed
Oct 12, 2021
sycl/include/sycl/ext/intel/experimental/esimd/emu/detail/esimdemu_device_interface.hpp
Outdated
Show resolved
Hide resolved
…demu_device_interface.hpp Co-authored-by: kbobrovs <Konstantin.S.Bobrovsky@intel.com>
kbobrovs
previously approved these changes
Oct 14, 2021
|
I found out that there is another PR (#4636 (comment)) for renaming esimd_cpu without my knowledge. I'll go with 'ESIMD_EMULATOR/esimd_emulator' for every ESIMD_CPU/esimd_cpu symbols. As @kbobrovs suggested 'EMULATOR' for the macro in the PR (#4636 (comment)). |
|
@kbobrovs , @againull , @smaslov-intel , would you review and approve this PR? |
againull
approved these changes
Oct 14, 2021
|
@kychendev , @v-klochkov , would you review and approve this PR? |
kychendev
approved these changes
Oct 15, 2021
kbobrovs
approved these changes
Oct 15, 2021
dongkyunahn-intel
added a commit
to dongkyunahn-intel/llvm
that referenced
this pull request
Jan 18, 2022
- Log-in suppression - 'cpu' to 'emu' (PR intel#4728)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change set is to change the name of ESIMD CPU emulation feature from ESIMD_CPU to ESIMD_EMU