[SYCL][Doc] Clarify restrictions on device global variables #4697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the restrictions for declaring variables of type `device_global`. These restrictions are similar to those we have already for `specialization_id` variables. The restriction against arrays of `device_global` variables is not strictly necessary, but it would take extra effort to implement and we do not have a compelling use case. We could lift the restriction later if we find a need.
|
Ping to spec reviewers. Perhaps @mkinsner or @rolandschulz are good candidates to approve? |
jbrodman
previously approved these changes
Oct 26, 2021
|
@bader: Can this be merged? This PR changes only the extension API specification, and a member of @intel/dpcpp-specification-reviewers has signed off. |
|
@gmlueck, can you please resolve a conflict in |
Done. |
|
ping to @dm-vodopyanov. Can this be merged now? The conflicts are resolved. |
bader
changed the title
gmlueck
added a commit
to gmlueck/llvm
that referenced
this pull request
Nov 15, 2021
Since PR intel#4697 was merged, there is no need to point to that PR. Instead, just point to the extension specification for device global.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the restrictions for declaring variables of type
device_global. These restrictions are similar to those we havealready for
specialization_idvariables.The restriction against arrays of
device_globalvariables is notstrictly necessary, but it would take extra effort to implement and
we do not have a compelling use case. We could lift the restriction
later if we find a need.