[SYCL] Remove unnecessary kernel ID protector mutex #4537
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kernel ID cache is only written to during `ProgramManager::AddImages` which is done at the start of the execution. All subsequent accesses to the kernel ID cache are reads. As such, the mutex that protects the kernel ID cache is only guarding reads, which adds an unnecessary overhead. Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
s-kanaev
reviewed
Sep 10, 2021
| @@ -275,15 +275,8 @@ class ProgramManager { | |||
| /// Maps names of kernels to their unique kernel IDs. | |||
| /// TODO: Use std::unordered_set with transparent hash and equality functions | |||
| /// when C++20 is enabled for the runtime library. | |||
| /// Access must be guarded by the m_KernelIDsMutex mutex | |||
| std::unordered_map<std::string, kernel_id> m_KernelIDs; | |||
There was a problem hiding this comment.
A note should be placed here saying that write access is only allowed during start-up process in addImages.
There was a problem hiding this comment.
Good idea. I've added a note.
Signed-off-by: Steffen Larsen <steffen.larsen@intel.com>
|
@romanovvlad Pointed out in another comment that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The kernel ID cache is only written to during
ProgramManager::addImageswhich is done at the start of program execution. All subsequent accesses to the kernel ID cache are reads. As such, the mutex that protects the kernel ID cache is only guarding reads, which adds an unnecessary overhead.