[SYCL] Remove the __SYCL_NVPTX__ macro #3977
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also includes a relevant stylistic fix suggested in intel#3869 (comment). Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
AGindinson
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
2 tasks
bader
reviewed
Jun 23, 2021
Since the macro is identical to a combination of `__SYCL_DEVICE_ONLY__` and `__NVPTX__`, showing up in the same circumstances (SYCL device compilation with an NVPTX triple), drop `__SYCL_NVPTX__` as unnecessary and solely rely on the combination of pre-existing macros. Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
AGindinson
changed the title
bader
reviewed
Jun 23, 2021
added 2 commits
June 24, 2021 07:33
Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
bader
previously approved these changes
Jun 24, 2021
romanovvlad
previously approved these changes
Jun 24, 2021
Signed-off-by: Artem Gindinson <artem.gindinson@intel.com>
|
@bader @elizabethandrews @romanovvlad I've rebased onto AMD GPU support, fixing a misspell in |
bader
approved these changes
Jun 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the macro is identical to a combination of
__SYCL_DEVICE_ONLY__and__NVPTX__, showing up in the samecircumstances (SYCL device compilation with an NVPTX triple), drop
__SYCL_NVPTX__as unnecessary and solely rely on the combination ofpre-existing macros.
Signed-off-by: Artem Gindinson artem.gindinson@intel.com