[SYCL] Fix post commit after PR 2292 #3939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes post commit caused by incorrect declaration of `cl` namespace: https://github.com/intel/llvm/runs/2838178517: ``` In file included from /home/runner/work/llvm/llvm/src/sycl/unittests/scheduler/FailedCommands.cpp:10: /home/runner/work/llvm/llvm/src/sycl/unittests/scheduler/SchedulerTestUtils.hpp:25:11: error: inline namespace reopened as a non-inline namespace [-Werror,-Winline-namespace-reopened-noninline] namespace cl { ^ inline /home/runner/work/llvm/llvm/src/sycl/source/detail/stream_impl.hpp:20:25: note: previous definition is here __SYCL_INLINE_NAMESPACE(cl) { ^ 1 error generated. ```
vladimirlaz
approved these changes
Jun 16, 2021
|
@pvchupin, can you please merge this patch in your time zone to get rid of post-commit failure as soon as possible? |
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jun 18, 2021
* upstream/sycl: (776 commits) Align CMake requirements with upstream. (intel#3928) [SYCL] Deprecate [[intel::reqd_work_group_size]] attribute spelling (intel#3927) [SYCL] Fix post commit after PR 2292 (intel#3939) {SYCL][PI][L0] - Eliminate std::string construction/destruction overhead. (intel#3931) [ESIMD] Overloading sycl sin,cos,exp,log functions for ESIMD arguments (intel#3717) [sycl-post-link] Add device image property for assert feature (intel#3881) [SYCL] Split read/write lockings (intel#2292) Handle OpSpecConstantOp with Select Handle OpSpecConstantOp with SMod Add tests for SConvert, UConvert, BitCast OpSpecConstantOp Fix attachment of decoration to spec constants Implement support for dynamic memmove Align clang-tidy/format versions to LLVM version Handle OpSpecConstantOp for integer comparisons Handle OpSpecConstantOp for SNegate, Not, and LogicalNot Extend OpSpecConstantOp testing for initializers Use IRBuilder for folding Fix translating of compile unit Support buffers in LinalgFoldUnitExtentDims [gn build] Port d0a5d86 ...
dm-vodopyanov
deleted the
private/dvodopya/fix-postcommit-after-pr2292
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes post commit caused by incorrect declaration
of
clnamespace:https://github.com/intel/llvm/runs/2838178517: