[NFC][SYCL] Fix -Wreorder warning about order of initialization #3660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inside LoopAttributes::LoopAttributes(bool IsParallel) in CGLoopInfo.cpp file, SYCLIntelFPGAVariantCount is initialized after SYCLSpeculatedIterationsNIterations. Change the order of declaration of these data members to avoid a -Wreorder warning. Signed-off-by: Soumi Manna <soumi.manna@intel.com>
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
smanna12
changed the title
smanna12
requested review from
AaronBallman,
elizabethandrews and
premanandrao
as code owners
AaronBallman
requested changes
Apr 29, 2021
There was a problem hiding this comment.
Why is it being initialized at all in the ctor? This is a SmallVector which default constructs just fine, but the constructor init list says SYCLIntelFPGAVariantCount(false) and I have no idea what that even does. :-D I think the correct fix is to remove the initialization from the ctor init list.
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
zahiraam
previously approved these changes
Apr 29, 2021
Signed-off-by: Soumi Manna <soumi.manna@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inside LoopAttributes::LoopAttributes(bool IsParallel) in CGLoopInfo.cpp file,
SYCLIntelFPGAVariantCount is initialized after SYCLSpeculatedIterationsNIterations.
/// Value for count variant (min/max/avg) and count metadata.
llvm::SmallVector<std::pair<const char *, unsigned int>, 2>
SYCLIntelFPGAVariantCount;
This patch removes the initialization from the ctor init list to avoid a -Wreorder warning since SYCLIntelFPGAVariantCount is defined as SmallVector which default constructs just fine here.