[SYCL][PL][L0]Fixes a deadlock that can occur with batching enabled. #3081
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change causes the event wait list for any command being enqueued to be checked to see if it was issued into a different queue than the command that will be waiting on it. If it was, then for batching to work properly, the currently open batch for that queue is closed and submitted for execution.
smaslov-intel
approved these changes
Jan 22, 2021
| @@ -4059,6 +4075,11 @@ pi_result piEnqueueEventsWaitWithBarrier(pi_queue Queue, | |||
| PI_ASSERT(Queue, PI_INVALID_QUEUE); | |||
| PI_ASSERT(Event, PI_INVALID_EVENT); | |||
|
|
|||
| _pi_ze_event_list_t TmpWaitList; | |||
vladimirlaz
pushed a commit
to intel/llvm-test-suite
that referenced
this pull request
Feb 10, 2021
…#139) The test was initially disabled due to a bug in the Level Zero plugin that led to a hang, which has already been fixed in intel/llvm#3081 Despite that, the test should stay disabled since the tested functionality is to be temporarily turned off for Level Zero in intel/llvm#3188
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…intel/llvm-test-suite#139) The test was initially disabled due to a bug in the Level Zero plugin that led to a hang, which has already been fixed in intel#3081 Despite that, the test should stay disabled since the tested functionality is to be temporarily turned off for Level Zero in intel#3188
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change causes the event wait list for any command being
enqueued to be checked to see if it was issued into a different
queue than the command that will be waiting on it. If it was,
then for batching to work properly, the currently open batch for
that queue is closed and submitted for execution.