[SYCL][NFC] Remove unused instances of WGSize array from work_group_size attributes #2983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eAttribute Template parameter support for work_group_size attributes was added on intel#2906. Unsigned WGSize array which was used on function checkWorkGroupSizeValues() befor the support for the attributes dimension values to check correctness of mutual usage of different work_group_size attributes: reqd_work_group_size, max_work_group_size and max_global_work_dim, does not use anymore. This patch removes instances of WGSize array from the WorkGroupSizeAttribute. Signed-off-by: Soumi Manna <soumi.manna@intel.com>
smanna12
changed the title
smanna12
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
|
Thanks @elizabethandrews for pointing this to me. |
jsji
pushed a commit
that referenced
this pull request
Feb 25, 2025
…ttribute change (#2983) Update after llvm/llvm-project@29441e4f5fa5 ("[IR] Convert from nocapture to captures(none)") Co-authored-by: Sven van Haastregt <sven.vanhaastregt@arm.com> Original commit: KhronosGroup/SPIRV-LLVM-Translator@290f13663fe0dfd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Template parameter support for work_group_size attributes was added on
#2906.
Unsigned WGSize array which was used on function checkWorkGroupSizeValues()
before the support for the attributes dimension values to check correctness of
mutual usage of different work_group_size attributes, does not use anymore.
This patch removes instances of WGSize array from the WorkGroupSizeAttribute.
Signed-off-by: Soumi Manna soumi.manna@intel.com