Skip to content

[SYCL] Add the notion of default contexts. #2805

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 52 commits into from
Sep 10, 2021
Merged

[SYCL] Add the notion of default contexts. #2805

merged 52 commits into from
Sep 10, 2021

Conversation

jbrodman
Copy link
Contributor

@jbrodman jbrodman commented Nov 20, 2020 •
edited by alexbatashev
Loading

A default context is now defined per platform. The default context initially contains all devices in the platform.
Queue creation will use the device's platform's default context instead of creating a new context with that device.

The new extension introduces ext_oneapi_get_default_context() member function to the platform class.

DPC++ runtime allows control of this feature with SYCL_ENABLE_DEFAULT_CONTEXTS env variable. It is enabled by default on Linux and disabled on Windows.

@jbrodman
Add the notion of a default context to a platform. Queue creation wil…
7d53b82 
…l use the platform's default context instead of creating a new context for the specified device.

Signed-off-by: James Brodman <james.brodman@intel.com>
@jbrodman
Update ABI symbols
664e6e1 
Signed-off-by: James Brodman <james.brodman@intel.com>
@jbrodman
Update tests to the new behavior
4292706 
Signed-off-by: James Brodman <james.brodman@intel.com>
@jbrodman
Update unit test for the new behavior
8ef4616 
Signed-off-by: James Brodman <james.brodman@intel.com>
@jbrodman
Make contexts in interop test explicit
8d5bc04 
Signed-off-by: James Brodman <james.brodman@intel.com>
@jbrodman
Change tests to use explicit contexts to keep exercising the original…
0bb715e 
… code path

Signed-off-by: James Brodman <james.brodman@intel.com>
@jbrodman
Add on-device tests and error when popping default context stack woul…
f13c910 
…d result in no default context

Signed-off-by: James Brodman <james.brodman@intel.com>
@jbrodman jbrodman requested a review from a team as a code owner November 20, 2020 18:44
alexbatashev
alexbatashev reviewed Nov 20, 2020
View reviewed changes
alexbatashev
alexbatashev reviewed Nov 20, 2020
View reviewed changes
olegmaslovatintel
olegmaslovatintel reviewed Jan 18, 2021
View reviewed changes
@jbrodman
Merge branch 'sycl' into defaultctxts
ef1592b
@jbrodman
Formatting/style changes
634af84 
Signed-off-by: James Brodman <james.brodman@intel.com>
@jbrodman
clang-format tests
5e55c1c 
Signed-off-by: James Brodman <james.brodman@intel.com>
alexbatashev
alexbatashev previously approved these changes Jan 24, 2021
View reviewed changes
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romanovvlad
Copy link
Contributor

@jbrodman Could you please point to the extension document?

@jbrodman
Add extension doc for platform contexts
76c94be 
Signed-off-by: James Brodman <james.brodman@intel.com>
romanovvlad
romanovvlad requested changes Jan 26, 2021
View reviewed changes
@jbrodman
Add mutex and update ABI
ea071c9 
Signed-off-by: James Brodman <james.brodman@intel.com>
@jbrodman
Update spec to have a table
6db087f 
Signed-off-by: James Brodman <james.brodman@intel.com>
romanovvlad
romanovvlad requested changes Jan 28, 2021
View reviewed changes
jbrodman added 3 commits March 17, 2021 15:46
@jbrodman
Merge branch 'sycl' into defaultctxts
bedea74
@jbrodman
Remove push/pop methods
5546f9b 
Signed-off-by: James Brodman <james.brodman@intel.com>
@jbrodman
Remove tests for push/pop
76d9322 
Signed-off-by: James Brodman <james.brodman@intel.com>
@jbrodman jbrodman requested a review from a team as a code owner March 17, 2021 20:21
romanovvlad
romanovvlad reviewed Mar 22, 2021
View reviewed changes
jbrodman added 2 commits May 18, 2021 11:10
@jbrodman
Address feedback. Change vector of contexts to a single one.
1b98a82 
Signed-off-by: James Brodman <james.brodman@intel.com>
@jbrodman
Add Platform Context extension to README.md
774a0be 
Signed-off-by: James Brodman <james.brodman@intel.com>
@alexbatashev
Copy link
Contributor

Tests should be fixed after intel/llvm-test-suite#433

@masterleinad masterleinad mentioned this pull request Sep 3, 2021
Merged
@alexbatashev
Copy link
Contributor

alexbatashev commented Sep 8, 2021 •
edited
Loading

SYCL :: Plugin/level_zero_dynamic_batch_test.cpp is failing. It is known to be flaky, not affected by this changeset.
There's a request to disable that test: intel/llvm-test-suite#453

bader
bader previously approved these changes Sep 8, 2021
View reviewed changes
s-kanaev
s-kanaev previously approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bader
bader reviewed Sep 8, 2021
View reviewed changes
@alexbatashev @bader
Update sycl/source/detail/queue_impl.hpp
08c72e7 
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
@alexbatashev alexbatashev dismissed stale reviews from s-kanaev and bader via 08c72e7 September 8, 2021 10:13
s-kanaev
s-kanaev approved these changes Sep 8, 2021
View reviewed changes
Copy link
Contributor

@s-kanaev s-kanaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexbatashev
Copy link
Contributor

@bader @romanovvlad do you know what's wrong with cuda build? It's been stuck for over a day, but I don't see a huge queue of other PRs.

@bader
Copy link
Contributor

bader commented Sep 9, 2021

do you know what's wrong with cuda build?

No.

@alexbatashev
Copy link
Contributor

The job status is still not updated. I reported this to tooling team. The difference between last commit and the previous one is just one comment, and the previous commit has this job passed. Can we assume that tests pass?

@romanovvlad romanovvlad merged commit 315593d into intel:sycl Sep 10, 2021
@bader
Copy link
Contributor

bader commented Sep 10, 2021

@romanovvlad, @alexbatashev, unittests do not pass on GitHub machines.
https://github.com/intel/llvm/runs/3564775299
Please, fix ASAP.

@npmiller npmiller mentioned this pull request Sep 10, 2021
Closed
DoyleLi pushed a commit to DoyleLi/intel_llvm that referenced this pull request Sep 13, 2021
@jbrodman @DoyleLi
[SYCL] Add support for default contexts (intel#2805)
18923e9 
A default context is now defined per platform. The default
context initially contains all devices in the platform. Queue
creation will use the device's platform's default context
instead of creating a new context with that device.

The new extension introduces ext_oneapi_get_default_context()
member function to the platform class.

DPC++ runtime allows control of this feature with
SYCL_ENABLE_DEFAULT_CONTEXTS env variable. It is enabled
by default on Linux and disabled on Windows.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbatashev alexbatashev alexbatashev left review comments

@olegmaslovatintel olegmaslovatintel olegmaslovatintel left review comments

@bader bader bader approved these changes

@romanovvlad romanovvlad romanovvlad approved these changes

@s-kanaev s-kanaev s-kanaev approved these changes

@pvchupin pvchupin Awaiting requested review from pvchupin

@mkinsner mkinsner Awaiting requested review from mkinsner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@jbrodman @romanovvlad @bader @alexbatashev @mkinsner @olegmaslovatintel @s-kanaev