Skip to content

[SYCL][L0]: Check Queue refcnt prior to using L0 members #2471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

nrspruit
Copy link
Contributor

  • If the Queue was cleared of L0 data structures ie Refcnt == 0
    then all L0 data structures in the pi_queue can no longer be used.
  • Prevent EventWait and EventRelease from using invalid data structures
    if the Queue has already been cleared.

Signed-off-by: Spruit, Neil R neil.r.spruit@intel.com

Copy link
Contributor

@smaslov-intel smaslov-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…elease

- If the Queue was cleared of L0 data structures ie Refcnt == 0
  then all L0 data structures in the pi_queue can no longer be used.
- Prevent EventWait and EventRelease from using invalid data structures
  if the Queue has already been cleared.

Signed-off-by: Spruit, Neil R <neil.r.spruit@intel.com>
@smaslov-intel
Copy link
Contributor

@againull can you merge this please?

@againull againull merged commit 93081e1 into intel:sycl Sep 15, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Sep 17, 2020
* upstream/sycl: (405 commits)
  [SYCL] Implement new env var SYCL_DEVICE_FILTER (intel#2239)
  [Driver][SYCL] Make /MD the default for -fsycl (intel#2478)
  [SYCL]: basic support of contexts with multiple devices in Level-Zero (intel#2440)
  [SYCL] Fix LIT regression after 9dd18ca (intel#2481)
  [SYCL][L0] Kernel Destroy in piKernelRelease (intel#2475)
  [SYCL] Emit an aliased function only if it is used (intel#2430)
  [Driver][SYCL] Add defaultlib directive for sycl lib (intel#2464)
  [Driver][SYCL] Improve situations where .exe is added for AOT tools (intel#2467)
  [SYCL][L0]: Check Queue refcnt prior to using members in event wait/release (intel#2471)
  [SYCL] Unroll several loops in __init method accessor class (intel#2449)
  [SYCL][Doc] Add link to use pinned memory spec (intel#2463)
  [SYCL] Link SYCL device libraries by default. (intel#2400)
  Revert "[SYCL] XFAIL test blcoking pulldown"
  Avoid usage of deprecated "VectorType::getNumElements" (intel#737)
  Fix nullptr dereference (intel#741)
  Do not translate arbitrary precision operations without corresponding extensions (intel#714)
  Add Constrained Floating-Point Intrinsics support
  [SYCL] Take into account auxiliary cmake options for Level Zero loader
  [InstCombine] improve fold of pointer differences
  [InstCombine] add ptr difference tests; NFC
  ...
kbenzie pushed a commit to kbenzie/intel-llvm that referenced this pull request Feb 17, 2025
[L0] Fix issue with test include path
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
[L0] Fix issue with test include path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants