[Driver][SYCL] Improve -std setting behaviors for Windows #2461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using -std:arg on Windows, the std setting was not being applied to the device compilation. Make needed adjustements to allow this which is due to the -std option differences in regards to Windows.
AGindinson
reviewed
Sep 11, 2020
AGindinson
approved these changes
Sep 16, 2020
jsji
pushed a commit
that referenced
this pull request
Mar 28, 2024
Task Sequence Specification was created without explicitly reserving the 6411 token enum. During spec review, that number was reserved by CooperativeMatrixPrefetchINTEL, but Task Sequence was not updated to use a new enum at that point in time, resulting in development with the old enum. 6199 is the newly (confirmed) reserved token enum. Original commit: KhronosGroup/SPIRV-LLVM-Translator@08384971f4021b2
Chenyang-L
pushed a commit
that referenced
this pull request
Feb 18, 2025
[DeviceASAN] Register globals for the program
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using -std:arg on Windows, the std setting was not being applied
to the device compilation. Make needed adjustements to allow this
which is due to the -std option differences in regards to Windows.