Skip to content

[SYCL] Split read/write lockings #2292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Jun 16, 2021
Merged

[SYCL] Split read/write lockings #2292

merged 26 commits into from
Jun 16, 2021

Conversation

s-kanaev
Copy link
Contributor

No description provided.

[SYCL] Split read/write lockings
885b27a 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@s-kanaev
Copy link
Contributor Author

Need to eliminate event leak.

@bader
Copy link
Contributor

bader commented Oct 14, 2020

@s-kanaev, do you plan to merge this PR?

@s-kanaev
Copy link
Contributor Author

do you plan to merge this PR?

Yes. I need some time for it.

Sergey Kanaev added 3 commits October 14, 2020 17:30
Merge branch 'sycl' into private/s-kanaev/read-write-lock-split
4e414f1
Fix merge glitch
6358b17 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Fix merge glitch
fbb2246 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@bader
Copy link
Contributor

bader commented Apr 29, 2021

do you plan to merge this PR?

Yes. I need some time for it.

Just an observation - half a year has passed...

Sergey Kanaev added 6 commits May 11, 2021 19:58
Merge remote-tracking branch 'public/sycl' into private/s-kanaev/read…
80abcf5 
…-write-lock-split
Fix merge glitch
a503fa2 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Fix build issues
a7f93d9 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Fix style issues
d9fb9e7 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Merge branch 'sycl' into private/s-kanaev/read-write-lock-split
d271603
Fix unit test
a20ec6d 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@AlexeySachkov AlexeySachkov mentioned this pull request May 14, 2021
Closed
Sergey Kanaev added 5 commits May 20, 2021 12:25
Merge remote-tracking branch 'public/sycl' into private/s-kanaev/read…
b8ce021 
…-write-lock-split
Eliminate runtime failure
0cf1217 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Fix code style issue
d1e5b2c 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Fix build issues
97e5b43 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Fix code style issue
69732b0 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@s-kanaev s-kanaev marked this pull request as ready for review May 25, 2021 10:24
@s-kanaev s-kanaev requested a review from a team as a code owner May 25, 2021 10:24
@s-kanaev
Copy link
Contributor Author

/summary:run

@mfbalin
Copy link
Contributor

mfbalin commented Jun 4, 2021

Is this pull request going to enable simultaneous read access to common buffers from different devices?

@s-kanaev
Copy link
Contributor Author

s-kanaev commented Jun 8, 2021

@mfbalin , could you, please post an issue to intel/llvm?

@s-kanaev
Copy link
Contributor Author

s-kanaev commented Jun 8, 2021

@sergey-semenov , @v-klochkov , @alexanderfle , a friendly ping.

v-klochkov
v-klochkov reviewed Jun 10, 2021
View reviewed changes
v-klochkov
v-klochkov reviewed Jun 10, 2021
View reviewed changes
v-klochkov
v-klochkov reviewed Jun 10, 2021
View reviewed changes
v-klochkov
v-klochkov reviewed Jun 10, 2021
View reviewed changes
v-klochkov
v-klochkov reviewed Jun 10, 2021
View reviewed changes
s-kanaev
s-kanaev commented Jun 10, 2021
View reviewed changes
Address review comments
95cb36d 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@s-kanaev s-kanaev requested a review from v-klochkov June 10, 2021 16:23
@v-klochkov
Copy link
Contributor

Thank you for the additional fixes! Please address the new build fails.

alexanderfle
alexanderfle reviewed Jun 10, 2021
View reviewed changes
alexanderfle
alexanderfle reviewed Jun 10, 2021
View reviewed changes
Sergey Kanaev added 6 commits June 11, 2021 10:32
Fix build issues
f6b4d74 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Use event instead of command
949c42c 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Add comments
3dd86fe 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Merge remote-tracking branch 'public/sycl' into private/s-kanaev/read…
69e7ba4 
…-write-lock-split
Fix build issues
2702a21 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Eliminate lock-unlock sequence with no payload
e9fa434 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Address style issue
68e86a6 
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
alexanderfle
alexanderfle approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@alexanderfle alexanderfle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bader
Copy link
Contributor

bader commented Jun 12, 2021

@s-kanaev, please, take a look at pre-commit check fails.

@vladimirlaz vladimirlaz merged commit 652c903 into intel:sycl Jun 16, 2021
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request Jun 18, 2021
Merge remote-tracking branch 'upstream/sycl' into sycl2020_namespace
9f42f08 
* upstream/sycl: (776 commits)
  Align CMake requirements with upstream. (intel#3928)
  [SYCL] Deprecate [[intel::reqd_work_group_size]] attribute spelling (intel#3927)
  [SYCL] Fix post commit after PR 2292 (intel#3939)
  {SYCL][PI][L0] - Eliminate std::string construction/destruction overhead. (intel#3931)
  [ESIMD] Overloading sycl sin,cos,exp,log functions for ESIMD arguments (intel#3717)
  [sycl-post-link] Add device image property for assert feature (intel#3881)
  [SYCL] Split read/write lockings (intel#2292)
  Handle OpSpecConstantOp with Select
  Handle OpSpecConstantOp with SMod
  Add tests for SConvert, UConvert, BitCast OpSpecConstantOp
  Fix attachment of decoration to spec constants
  Implement support for dynamic memmove
  Align clang-tidy/format versions to LLVM version
  Handle OpSpecConstantOp for integer comparisons
  Handle OpSpecConstantOp for SNegate, Not, and LogicalNot
  Extend OpSpecConstantOp testing for initializers
  Use IRBuilder for folding
  Fix translating of compile unit
  Support buffers in LinalgFoldUnitExtentDims
  [gn build] Port d0a5d86
  ...
@AlexeySachkov AlexeySachkov mentioned this pull request Oct 3, 2022
Closed
jsji pushed a commit that referenced this pull request Jan 11, 2024
@linehill @sys-ce-bb
Use triple subarch to emit exact SPIR-V version (#2292)
e1b0fd9 
Use target triple's subarch component, if present, for setting exact
SPIR-V version for the SPIR-V emission.

Resolves #1509.

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@9f29f97
Chenyang-L pushed a commit that referenced this pull request Feb 18, 2025
@pbalcer
Merge pull request #2292 from zhaomaosu/disable-leak-check-exit-with-…
111182a 
…error

[DeviceASAN] Disable memory leak detection when asan exit with errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v-klochkov v-klochkov v-klochkov approved these changes

@alexanderfle alexanderfle alexanderfle approved these changes

@sergey-semenov sergey-semenov Awaiting requested review from sergey-semenov

@romanovvlad romanovvlad Awaiting requested review from romanovvlad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@s-kanaev @bader @mfbalin @v-klochkov @romanovvlad @alexanderfle @vladimirlaz