[SYCL-PTX] Add _Float16 as native type #1848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naghasan
requested review from
elizabethandrews,
Fznamznon and
premanandrao
as code owners
premanandrao
reviewed
Jun 9, 2020
Naghasan
force-pushed
the
cuda_native_float_16
branch
2 times, most recently
from
96b3e79 to
b1ffe4a
Compare
|
@Naghasan, could you apply clang-format to the patch, please? |
The NVPTX backend supports half and handle the insertion of conversion operations when required. Signed-off-by: Victor Lomuller <victor@codeplay.com>
This reverts commit a4f4fa9. Signed-off-by: Victor Lomuller <victor@codeplay.com>
Naghasan
force-pushed
the
cuda_native_float_16
branch
from
b1ffe4a to
a45ca0a
Compare
Fznamznon
approved these changes
Jun 11, 2020
KornevNikita
pushed a commit
to KornevNikita/llvm
that referenced
this pull request
Feb 20, 2023
This specifies the right operand types for GetKernelWorkGroupSize, GetKernelPreferredWorkGroupSizeMultiple, GetKernelNDrangeMaxSubGroupSize, and GetKernelNDrangeSubGroupCount to fix a function signature mismatch bug on reverse translation. Original commit: KhronosGroup/SPIRV-LLVM-Translator@f0366a6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NVPTX backend supports half and handle the insertion of conversion operations when required.
Resolves #1799
Signed-off-by: Victor Lomuller victor@codeplay.com