[SYCL][CUDA] Fixes CUDA unit tests that uses SYCL directly #1763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirlaz
previously approved these changes
May 28, 2020
bjoernknafla
force-pushed
the
steffen/fix-cuda-sycl-unittests
branch
from
1a4a55c to
5ae7af5
Compare
s-kanaev
previously approved these changes
May 29, 2020
|
@steffenlarsen, I looks like this PR conflicts with recently merged #1735. Could you resolve the conflict, please? |
steffenlarsen
force-pushed
the
steffen/fix-cuda-sycl-unittests
branch
from
5ae7af5 to
8778e16
Compare
The merge conflict has been fixed. I noticed that the conflicting change had a better way of selecting the valid platform, so I adopted it. |
steffenlarsen
force-pushed
the
steffen/fix-cuda-sycl-unittests
branch
from
8778e16 to
ee7ef20
Compare
CUDA-specific unit tests that use SYCL directly fail if another backend is in use. This commit fixes this by actively selecting CUDA platforms and only runs the tests on these. Signed-off-by: Steffen Larsen <steffen.larsen@codeplay.com>
steffenlarsen
force-pushed
the
steffen/fix-cuda-sycl-unittests
branch
from
ee7ef20 to
b29ee99
Compare
bader
approved these changes
May 29, 2020
s-kanaev
approved these changes
May 29, 2020
alexbatashev
pushed a commit
to alexbatashev/llvm
that referenced
this pull request
Jun 2, 2020
* upstream/sycl: [SYCL] Handle KernelName templated using type with enum template argument (intel#1780) [SYCL] Fix KernelNameInfo generated for empty template parameter pack (intel#1775) [SYCL] Do not export utility methods from SYCLMemObjT (intel#1768) [Driver][SYCL] Fix processing when using -fsycl-link (intel#1765) [SYCL][NFC] Remove outdated confusing comment (intel#1779) [SYCL][NFC] Wrap classes in .cpp into a namespace to disable external linkage. (intel#1776) [SYCL][CUDA] Fixes CUDA unit tests that uses SYCL directly (intel#1763) [SYCL][Doc] Fix default device selection rules doc (intel#1769) [SYCL][CUDA] Remove pi Event Callback implementation (intel#1735) [SYCL] Throw exception if range/offset of kernel execution exceeds INT_MAX (intel#1713) [SYCL-PTX] Add intermediate layer to libclc to ease type management (intel#1712)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CUDA-specific unit tests that use SYCL directly fail if another backend is in use. This fixes this by actively selecting CUDA platforms and only runs the tests on these.
Signed-off-by: Steffen Larsen steffen.larsen@codeplay.com