Export PI opencl function symbols using version script #1638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[CORC-7433] Enum variables were too commonly used by users. This kind of conflicts cannot be avoided 100%, but we can minimize the chance by using the prefix SYCL_ Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by : Byoungro So <byoungro.so@intel.com> Co-Authored-By: Alexey Bader <alexey.bader@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com> Co-Authored-By: Alexey Bader <alexey.bader@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
Also, added regression test for checking pi* export symbols Signed-off-by: Byoungro So <byoungro.so@intel.com>
smaslov-intel
previously approved these changes
May 7, 2020
|
@smaslov-intel But, I don't think I have write access. |
I think you have to rebase your code locally, and push the rebased version. |
Changed symbols from Oclpi* to pi* Set -fvisibility=hidden by default to hide all symbols. version script tells only pi* symbols are global. Signed-off-by: Byoungro So <byoungro.so@intel.com>
Cleaned up some unnecessary versioning code Changed library scope from SHARED to MODULE to limit its usage Moved duplicate code out of condition Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
already attached it in pi.h Signed-off-by: Byoungro So <byoungro.so@intel.com>
Also, added regression test for checking pi* export symbols Signed-off-by: Byoungro So <byoungro.so@intel.com>
…nto export-piopencl Signed-off-by: Byoungro So <byoungro.so@intel.com>
Signed-off-by: Byoungro So <byoungro.so@intel.com>
alexbatashev
suggested changes
May 8, 2020
Signed-off-by: Byoungro So <byoungro.so@intel.com>
moved it under test/abi/ Signed-off-by: Byoungro So <byoungro.so@intel.com>
alexbatashev
previously approved these changes
May 9, 2020
bader
reviewed
May 9, 2020
Signed-off-by: Byoungro So <byoungro.so@intel.com>
bader
approved these changes
May 9, 2020
alexbatashev
approved these changes
May 9, 2020
smaslov-intel
approved these changes
May 11, 2020
againull
added a commit
to againull/llvm
that referenced
this pull request
May 20, 2020
Align with changes made for OpenCL plugin in intel#1638: * Fix build on Windows by defining __SYCL_BUILD_SYCL_DLL in cmake file * Export only pi* symbols in libpi_level0.so * Add test to check exported symbols Signed-off-by: Artur Gainullin <artur.gainullin@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed symbol names from Oclpi* to pi* in pi_opencl.cpp.
Set -fvisibility=hidden to hide all symbols by default.
Version script is used to export only pi* symbols.