-
Notifications
You must be signed in to change notification settings - Fork 745
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL] Support scalar accessor in handler::copy(acc,ptr) and copy(ptr… #1634
Conversation
This is the second part of the fix for handler::copy(). The main motivation for me to fix it now is that missing handler::copy support for 0-dimensional accessors blocks the work on reduction feature. This patch is quite similar to the one I did few days ago for handler::copy(SrcAccessor, DstAccessor). |
9a2d4cf
to
03aa6c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just a small nit, can be ignored or handled separately
…,acc) Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
…_cast Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
2f77d05
to
650ff9e
Compare
buildbot/Lit_With_Cuda CI task is required. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM
…_docs * origin/sycl: [SYCL] Fix xmethod script deployment (intel#1645) [SYCL] Support scalar accessor in handler::copy(acc,ptr) and copy(ptr,acc) (intel#1634) [SYCL][CUDA] Reduction ext unsupported (intel#1641) [SYCL][NFC] Simplifying contribution guidelines (intel#1644)
Update a check pattern after LLVM commit 189900e ("X86: Stop assigning register costs for longer encodings.", 2022-09-30). Original commit: KhronosGroup/SPIRV-LLVM-Translator@a3b372c
…,acc)
Signed-off-by: Vyacheslav N Klochkov vyacheslav.n.klochkov@intel.com