Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL] Support scalar accessor in handler::copy(acc,ptr) and copy(ptr… #1634

Merged
merged 3 commits into from
May 7, 2020

Conversation

v-klochkov
Copy link
Contributor

…,acc)

Signed-off-by: Vyacheslav N Klochkov vyacheslav.n.klochkov@intel.com

@v-klochkov v-klochkov requested a review from a team as a code owner May 2, 2020 07:20
@v-klochkov
Copy link
Contributor Author

v-klochkov commented May 2, 2020

This is the second part of the fix for handler::copy().

The main motivation for me to fix it now is that missing handler::copy support for 0-dimensional accessors blocks the work on reduction feature.

This patch is quite similar to the one I did few days ago for handler::copy(SrcAccessor, DstAccessor).
#1551

@v-klochkov v-klochkov force-pushed the public_vklochkov_copy_0dim_final branch from 9a2d4cf to 03aa6c8 Compare May 2, 2020 07:27
alexbatashev
alexbatashev previously approved these changes May 6, 2020
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Just a small nit, can be ignored or handled separately

sycl/include/CL/sycl/handler.hpp Outdated Show resolved Hide resolved
romanovvlad
romanovvlad previously approved these changes May 6, 2020
sycl/include/CL/sycl/handler.hpp Show resolved Hide resolved
@v-klochkov v-klochkov dismissed stale reviews from romanovvlad and alexbatashev via 2f77d05 May 6, 2020 22:13
v-klochkov added 3 commits May 6, 2020 15:13
…,acc)

Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
…_cast

Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
@v-klochkov v-klochkov force-pushed the public_vklochkov_copy_0dim_final branch from 2f77d05 to 650ff9e Compare May 6, 2020 22:13
@v-klochkov
Copy link
Contributor Author

buildbot/Lit_With_Cuda CI task is required.
Due to some glitch in CI it has not even started. I don't see it in the list of CI tasks.
Thus I added the 3rd [NFC] commit to address Alexander's comment, and also re-based the patch to re-start CI testing.

@v-klochkov v-klochkov requested a review from alexbatashev May 6, 2020 22:26
Copy link
Contributor

@alexbatashev alexbatashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still LGTM

@bader bader requested a review from romanovvlad May 7, 2020 08:27
@bader bader merged commit aedd449 into intel:sycl May 7, 2020
alexbatashev pushed a commit to alexbatashev/llvm that referenced this pull request May 7, 2020
…_docs

* origin/sycl:
  [SYCL] Fix xmethod script deployment (intel#1645)
  [SYCL] Support scalar accessor in handler::copy(acc,ptr) and copy(ptr,acc) (intel#1634)
  [SYCL][CUDA] Reduction ext unsupported (intel#1641)
  [SYCL][NFC] Simplifying contribution guidelines (intel#1644)
@v-klochkov v-klochkov deleted the public_vklochkov_copy_0dim_final branch May 7, 2020 16:05
preethi-intel pushed a commit to preethi-intel/llvm that referenced this pull request Oct 5, 2022
Update a check pattern after LLVM commit 189900e ("X86: Stop
assigning register costs for longer encodings.", 2022-09-30).

Original commit:
KhronosGroup/SPIRV-LLVM-Translator@a3b372c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants