[SYCL][ClangLinkerWrapper] Fix read of invalid memory #15472
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
sarnex
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sarnex
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
asudarsa
reviewed
Sep 25, 2024
| // the file. | ||
| StringRef UnbundledArchiveList = | ||
| Args.MakeArgString((*ObjList)->getBuffer()); | ||
| UnbundledArchiveList.split(ObjectFilePaths, '\n', /*MaxSplit=*/-1, |
There was a problem hiding this comment.
Where will this variable be used? Not a blocking question.
There was a problem hiding this comment.
Thanks for the review. It's used here, we immediately split it into the ObjectFilePaths vector .
There was a problem hiding this comment.
Ah..of course..I was naive and was looking for this variable on the RHS of an assignment statement. :-(. Thinking more, may be not so naive. I was just wondering where else we would be using UnbundledArchiveList that we needed to store it.
asudarsa
approved these changes
Sep 25, 2024
|
@intel/llvm-gatekeepers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was the buffer gets freed when we go out of the
ifbecause theunique_ptris created there, so just make a copy that will stay alive as long as we need it. Confirmed fix with valgrind.This is already tested by
sycl/test-e2e/NewOffloadDriver/multisource.cppand it fails sporadically which led me to this fix.