-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][NFCI] Rework spec constants metadata used for split #15346
Conversation
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me!
// extract spec constant maps per each module | ||
SpecIDMapTy TmpSpecIDMap; | ||
SpecConstantsPass::collectSpecConstantMetadata(M, TmpSpecIDMap); | ||
if (!TmpSpecIDMap.empty()) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that both spec constants metadata and default values metadata are in sync, i.e. if one is empty then another is also empty. However, I wonder if we need to note that in a comment, or in form of some assert
in else
branch put under #ifndef NDEBUG
?
I'm just looking for what others think, I do not have a strong opinion here, so not asking to do any changes just yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems reasonable to me, let me add it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running unit tests, it seems it actually is the case that TmpSpecIDMap
is empty but IsSpecConstantDefault
is true, and I'm not sure if there are any other cases that should bet rue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging for now, let me know if you have any other ideas on something we can assert, happy to implement it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running unit tests, it seems it actually is the case that
TmpSpecIDMap
is empty butIsSpecConstantDefault
is true, and I'm not sure if there are any other cases that should bet rue.
What I meant is that collectSpecConstantMetadata
and collectSpecConstantMetadata
should either both return empty map, or should both return non-empty map. That's the implicit expectation we currently have.
I'm not sure what IsSpecConstantDefault
is, but if that's a marker that device image contains default values of spec constants then it is also a weird state. That image should not be produced if there are no spec constants, because it will be no different from the original device image it was produced from. We even have an early exit in the corresponding function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry the two functions you mentioned are the same, did you mean collectSpecConstantMetadata
and collectSpecConstantDefaultValuesMetadata
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, copy-paste mistake
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that seems to work, pr coming soon. thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow up from #15346. Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Addressing review feedback from #15271