[SYCL][NFCI] Rework spec constants metadata used for split - #15346
Conversation
Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
GitHub Actions
Inactive
GitHub Actions
Inactive
AlexeySachkov
left a comment
AlexeySachkov
left a comment
There was a problem hiding this comment.
Overall looks good to me!
| // extract spec constant maps per each module | ||
| SpecIDMapTy TmpSpecIDMap; | ||
| SpecConstantsPass::collectSpecConstantMetadata(M, TmpSpecIDMap); | ||
| if (!TmpSpecIDMap.empty()) { |
There was a problem hiding this comment.
I assume that both spec constants metadata and default values metadata are in sync, i.e. if one is empty then another is also empty. However, I wonder if we need to note that in a comment, or in form of some assert in else branch put under #ifndef NDEBUG?
I'm just looking for what others think, I do not have a strong opinion here, so not asking to do any changes just yet.
There was a problem hiding this comment.
That seems reasonable to me, let me add it.
There was a problem hiding this comment.
Running unit tests, it seems it actually is the case that TmpSpecIDMap is empty but IsSpecConstantDefault is true, and I'm not sure if there are any other cases that should bet rue.
There was a problem hiding this comment.
Merging for now, let me know if you have any other ideas on something we can assert, happy to implement it.
There was a problem hiding this comment.
Running unit tests, it seems it actually is the case that
TmpSpecIDMapis empty butIsSpecConstantDefaultis true, and I'm not sure if there are any other cases that should bet rue.
What I meant is that collectSpecConstantMetadata and collectSpecConstantMetadata should either both return empty map, or should both return non-empty map. That's the implicit expectation we currently have.
I'm not sure what IsSpecConstantDefault is, but if that's a marker that device image contains default values of spec constants then it is also a weird state. That image should not be produced if there are no spec constants, because it will be no different from the original device image it was produced from. We even have an early exit in the corresponding function
There was a problem hiding this comment.
Sorry the two functions you mentioned are the same, did you mean collectSpecConstantMetadata and collectSpecConstantDefaultValuesMetadata?
There was a problem hiding this comment.
Right, copy-paste mistake
There was a problem hiding this comment.
that seems to work, pr coming soon. thanks
Follow up from #15346. Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
2 participants
Addressing review feedback from #15271