[SYCL][Doc][WIP][DO-NOT-MERGE] Draft extension that simplifies accessors and reduces their verbosity #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Kinsner <michael.kinsner@intel.com>
jbrodman
approved these changes
Apr 9, 2020
|
@mkinsner, I converted this PR to a draft to prevent from accidental merge. |
bader
added
the
spec extension
|
@mkinsner, do you think it's ready for review? |
bader
pushed a commit
that referenced
this pull request
Jun 18, 2020
This patch adds the implementation of [SYCL_INTEL_accessor_simplification](#1498) extension. It adds: - `host_accessor` - `read_only`, `write_only`, `read_write`, `read_constant` tags - `noinit` property - a number of constructors for both buffer `accessor` and `host_accessor` to utilize newly added tags and properties for usage simplification Most use cases for `accessor` has no longer need for specifying template arguments and rely on deduction guides and corresponding tags. `sycl::access::target` is now accessible from `sycl::target` and `sycl::access::mode` from `sycl::access_mode`
bader
pushed a commit
that referenced
this pull request
Jul 13, 2020
This patch adds host task functionality of [SYCL_INTEL_accessor_simplification](#1498) extension. `handler` type is now valid argument for `host_accessor` and `buffer.get_host_access()`, which enables non-blocking behavior, while accessing memory on the host.
|
This extension has been superseded by the SYCL 2020 provisional specification, which is an iteration of this proposal. Closing this PR since the provisional Khronos spec captures the content in an evolved form. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Kinsner michael.kinsner@intel.com