[SYCL][COMPAT] Add math extend_v*2 to SYCLCompat
#13953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
force-pushed
the
math_extend_v2
branch
from
01466b7
to
2f908c4
Compare
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
joeatodd
requested changes
May 31, 2024
There was a problem hiding this comment.
Thanks for this @OuadiElfarouki! I left a few comments which largely follow the discussion we've been having in the team.
I think we need to decide what we want to do about permitting mixed signed/unsigned types. Exhaustively testing every combination is probably intractable, but we could test all 8 permutations of signed/unsigned, signed/unsigned, signed/unsigned for at least one or two of the extend_v*2 APIs.
@Alcpz what are your thoughts on that?
|
We'll also need to add the APIs to the README, but let's wait till we resolve the rest of the stuff to avoid duplication of effort. |
Alcpz
reviewed
May 31, 2024
Co-authored-by: Alberto Cabrera Pérez <alberto.cabrera@intel.com>
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Co-authored-by: Joe Todd <joe.todd@codeplay.com>
OuadiElfarouki
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
OuadiElfarouki
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
This was referenced Jun 6, 2024
OuadiElfarouki
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
OuadiElfarouki
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers PR is ready for merge. (The #14078 can be addressed later) 🙏🏻 |
steffenlarsen
pushed a commit
that referenced
this pull request
Jun 12, 2024
This PR adds math `extend_v*4` operators (18 in total) along with unit-tests for signed and unsigned int32 cases. *Some changes overlap with the previous `extend_v*2` PR #13953 and thus should be reviewed/merged first. --------- Co-authored-by: Alberto Cabrera Pérez <alberto.cabrera@intel.com> Co-authored-by: Joe Todd <joe.todd@codeplay.com> Co-authored-by: Yihan Wang <yihan.wang@intel.com>
ianayl
pushed a commit
to ianayl/sycl
that referenced
this pull request
Jun 13, 2024
This PR adds math `extend_v*2` operators _(18 in total)_ along with unit-tests for signed and unsigned `int32` cases. --------- Co-authored-by: Alberto Cabrera Pérez <alberto.cabrera@intel.com> Co-authored-by: Joe Todd <joe.todd@codeplay.com>
ianayl
pushed a commit
to ianayl/sycl
that referenced
this pull request
Jun 13, 2024
This PR adds math `extend_v*4` operators (18 in total) along with unit-tests for signed and unsigned int32 cases. *Some changes overlap with the previous `extend_v*2` PR intel#13953 and thus should be reviewed/merged first. --------- Co-authored-by: Alberto Cabrera Pérez <alberto.cabrera@intel.com> Co-authored-by: Joe Todd <joe.todd@codeplay.com> Co-authored-by: Yihan Wang <yihan.wang@intel.com>
steffenlarsen
pushed a commit
that referenced
this pull request
Jun 14, 2024
This PR adds math `extend_vcompare[2/4] `operators (4 in total) along with unit-tests for signed and unsigned int32 cases. Also, Unit-tests from previous `extend_v*4` #14078 and `extend_v*2` #13953 are moved to two different files. --------- Co-authored-by: Alberto Cabrera Pérez <alberto.cabrera@intel.com> Co-authored-by: Joe Todd <joe.todd@codeplay.com> Co-authored-by: Yihan Wang <yihan.wang@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds math
extend_v*2operators (18 in total) along with unit-tests for signed and unsignedint32cases.