Skip to content

[SYCL][Fusion] Enable fusion of rounded-range kernels #12492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2024

Conversation

jopperm
Copy link
Contributor

@jopperm jopperm commented Jan 25, 2024

Enable, test, and document the support for fusing rounded range kernels. This mostly worked already – we just have to query the original kernel's global size, and use that to compute the private memory size used for internalization.

@jopperm jopperm self-assigned this Jan 25, 2024
@jopperm jopperm requested a review from a team as a code owner January 25, 2024 05:20
Copy link
Contributor

@sommerlukas sommerlukas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question inline.

Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
@jopperm
Copy link
Contributor Author

jopperm commented Jan 30, 2024

@intel/llvm-gatekeepers Could you merge this, please?

@sommerlukas sommerlukas merged commit a3e2315 into intel:sycl Jan 31, 2024
@jopperm jopperm deleted the kf-rr branch January 31, 2024 08:16
sommerlukas pushed a commit that referenced this pull request Jan 31, 2024
Silence unused variable warning which tripped post-commit checks for
#12492.

Signed-off-by: Julian Oppermann <julian.oppermann@codeplay.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants