Skip to content

[SYCL][NFC] Remove unwanted flag when storing original exception message #1157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 25, 2020

Conversation

s-kanaev
Copy link
Contributor

Signed-off-by: Sergey Kanaev sergey.kanaev@intel.com

Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
/// due to the possibility of error code being equal to zero even in case
/// if build is failed and cl::sycl::exception is thrown.
bool FilledIn;
bool isFilledIn() const {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bool isFilledIn() const {
inline bool isFilledIn() const {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why?

@bader bader merged commit e2130b1 into intel:sycl Feb 25, 2020
@s-kanaev s-kanaev deleted the private/s-kanaev/fix branch February 26, 2020 06:33
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Feb 23, 2023
content.cpp has been failing on OpenCL CPU for some environments. This
commit disables this test until this problem has been fixed.

Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants