-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][Graph][L0] Reset L0 events for UR sync-points #11553
Conversation
The Unified Runtime sync-points used to represent SYCL-Graph edges are not correctly implemented for the Level Zero adapter. The L0 events used to implement them are not reset to the non-signalled state after an enqueue of the graph. Fixed in the UR L0 adapter change oneapi-src/unified-runtime#965 which resets the UR events to the non-signalled state at the end of the L0 command-list.
Point to the most recent UR commit for this change and update the design doc diagram to reflect the changes from this patch to L0 command-lists used to implement a UR command-buffer.
9dba140
to
68e2d95
Compare
CI fails on the PR look unrelated.
|
thanks @EwanC , For #11312, we are reverting those changes in oneapi-src/unified-runtime#972. Please rebase once that is merged and relaunch. |
Currently Github pr thinks file is invalid
@intel/llvm-gatekeepers Can we merge this to unblock merging the next unified-runtime PR in the queue. |
The Unified Runtime sync-points used to represent SYCL-Graph edges have a bug in the implementation of the Level Zero adapter. The L0 events used to implement the sync-points are not reset to the non-signaled state after an enqueue of the graph.
Fixed in the UR L0 adapter change oneapi-src/unified-runtime#965 which resets the UR events to the non-signaled state at the end of the L0 command-list.