[SYCL][Fusion] Add HIP support #11003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The patch add support for HIP via the libamd_comgr: - Add build path in sycl-fusion - Add finalization routine inside hip adapter's build program Signed-off-by: Victor Lomuller <victor@codeplay.com>
Naghasan
force-pushed
the
victor/kernel-fusion-amd
branch
from
3e27075 to
803ca51
Compare
Naghasan
requested review from
victor-eds,
sommerlukas and
a team
as code owners
JackAKirk
reviewed
Sep 18, 2023
sommerlukas
reviewed
Sep 18, 2023
sycl/test-e2e/KernelFusion/abort_internalization_stored_ptr.cpp
Outdated
Show resolved
Hide resolved
victor-eds
reviewed
Sep 18, 2023
sommerlukas
reviewed
Sep 19, 2023
There was a problem hiding this comment.
A few other nits outside of code changes:
- Should probably update https://github.com/intel/llvm/blob/sycl-mlir/sycl/doc/design/KernelFusionJIT.md
- So far, we have been using
[SYCL][Fusion]for the tag in the commit message, so would be good to keep it consistent. - We could remove the mention of the draft status from the PR/commit description.
Naghasan
changed the title
sommerlukas
approved these changes
Sep 20, 2023
Co-authored-by: Lukas Sommer <lukas.sommer@codeplay.com>
sommerlukas
approved these changes
Sep 20, 2023
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
reviewed
Oct 3, 2023
mdtoguchi
approved these changes
Oct 3, 2023
|
ping @intel/dpcpp-l0-pi-reviewers @intel/llvm-reviewers-runtime |
jopperm
approved these changes
Oct 10, 2023
smaslov-intel
approved these changes
Oct 10, 2023
|
@Naghasan now that oneapi-src/unified-runtime#940 is merged please pull in the latest diff --git a/sycl/plugins/unified_runtime/CMakeLists.txt b/sycl/plugins/unified_runtime/CMakeLists.txt
index 20aae8927f0b..88b328e8daab 100644
--- a/sycl/plugins/unified_runtime/CMakeLists.txt
+++ b/sycl/plugins/unified_runtime/CMakeLists.txt
@@ -54,13 +54,13 @@ if(SYCL_PI_UR_USE_FETCH_CONTENT)
include(FetchContent)
set(UNIFIED_RUNTIME_REPO "https://github.com/oneapi-src/unified-runtime.git")
- # commit 3a3aae387eaa8aa072ff310b94df83c9d1a33a0b
- # Merge: 614e6d0 b4425bc
+ # commit cf26de283a1233e6c93feb085acc10c566888b59
+ # Merge: 3a3aae38 2fd9dea2
# Author: Kenneth Benzie (Benie) <k.benzie@codeplay.com>
- # Date: Mon Oct 23 14:49:01 2023 +0100
- # Merge pull request #945 from npmiller/fix-priority
- # [CUDA] Fix queue creation with native handle
- set(UNIFIED_RUNTIME_TAG 3a3aae387eaa8aa072ff310b94df83c9d1a33a0b)
+ # Date: Wed Oct 25 10:36:48 2023 +0100
+ # Merge pull request #940 from Naghasan/victor/kernel-fusion-amd
+ # [UR][HIP] Enable kernel finalization using comgr
+ set(UNIFIED_RUNTIME_TAG cf26de283a1233e6c93feb085acc10c566888b59)
if(SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO)
set(UNIFIED_RUNTIME_REPO "${SYCL_PI_UR_OVERRIDE_FETCH_CONTENT_REPO}") |
|
thanks @kbenzie |
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
ping @intel/llvm-reviewers-runtime |
steffenlarsen
approved these changes
Oct 25, 2023
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Naghasan
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patch add support for HIP via the libamd_comgr: