[ESIMD] Fix unary math functions accepting saturation tag; fix ext_math.cpp test #10848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt_math.cpp test The test ext_math.cpp needed the fix for half type to avoid having NaNs in inputs. Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
v-klochkov
force-pushed
the
esimd_saturate_intrin
branch
from
672aae2 to
37ddd6c
Compare
…math_saturate.cpp Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
Signed-off-by: Vyacheslav N Klochkov <vyacheslav.n.klochkov@intel.com>
turinevgeny
reviewed
Aug 17, 2023
turinevgeny
approved these changes
Aug 21, 2023
|
The CI AMD/HIP fails are unrelated to this PR. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test ext_math.cpp needed the fix for half type to avoid having only NaNs in inputs.
This patch also fixes the comment for saturate function when source and destination type
is same FP type. The previous comment wrongly said saturate() would clamp value to the range [-1.0, 1.0],
while in fact ESIMD intrinsic saturate and it is HW version always clamped to [0.0-1.0].