[SYCL][Bindless] Fix compiler Werrors #10464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed compiler errors/warnings related to unused and uninitialized variables and parameters. Post-commit fix for PR: intel#10112
jchlanda
reviewed
Jul 19, 2023
| @@ -131,8 +131,7 @@ cudaToUrImageChannelFormat(CUarray_format cuda_format, | |||
| } | |||
| } | |||
|
|
|||
| ur_result_t urTextureCreate(ur_context_handle_t hContext, | |||
There was a problem hiding this comment.
This changes the signature of the function, is that intentional?
There was a problem hiding this comment.
Yes, this is just an internal helper function and we don't need the hContext parameter.
jchlanda
approved these changes
Jul 19, 2023
fabiomestre
pushed a commit
to fabiomestre/llvm
that referenced
this pull request
Sep 26, 2023
- Fixed compiler errors/warnings related to unused and uninitialized variables and parameters. Post-commit fix for PR: intel#10112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post-commit fix for PR: #10112