Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bindless_images/read_sampled.cpp validation error on cuda/DG2 #15671

Open
wenju-he opened this issue Oct 11, 2024 · 2 comments
Open

bindless_images/read_sampled.cpp validation error on cuda/DG2 #15671

wenju-he opened this issue Oct 11, 2024 · 2 comments
Labels
bug Something isn't working sycl-bindless-images SYCL Bindless Images

Comments

@wenju-he
Copy link
Contributor

wenju-he commented Oct 11, 2024

Describe the bug

char/uchar/short/ushort types in test read_sampled.cpp has validation error on DG2 and the difference is 1.

If we add int32 type to the test, the test will also report error on CUDA and difference is also 1:

addressing mode: repeat
coordinate normalization mode: normalized
filtering mode: linear
offset: 1.25
Running 2D int
Global Size: 32 32  Local Size: 8 8
        Result mismatch at [4][0] Expected: 38, Actual: 37
        Result mismatch at [7][0] Expected: 54, Actual: 53
        Result mismatch at [8][0] Expected: 50, Actual: 49

Is this a test issue related to reference value computation? Tag @intel/bindless-images-reviewers

To reproduce

  1. Apply following diff to the test
diff --git a/sycl/test-e2e/bindless_images/read_sampled.cpp b/sycl/test-e2e/bindless_images/read_sampled.cpp
index 3e786855381e..3e4e640bc41e 100644
--- a/sycl/test-e2e/bindless_images/read_sampled.cpp
+++ b/sycl/test-e2e/bindless_images/read_sampled.cpp
@@ -587,6 +587,12 @@ bool runTests(sycl::range<2> dims, sycl::range<2> localSize, float offset,
       failed |= util::runTest<NDims, float, 4, sycl::image_channel_type::fp32,
                               class float4_2d2>({512, 512}, {8, 8}, offset,
                                                 samp, seed);
+
+      bindless_helpers::printTestName<NDims>("Running 2D int", {32, 32},
+                                             {8, 8});
+      failed |= util::runTest<NDims, int, 1, sycl::image_channel_type::signed_int32,
+                              class int_2d>({512, 512}, {8, 8}, offset,
+                                            samp, seed);
     }
   }
  1. Specify the command which should be used to compile the program
    clang++ -fsycl read_sampled.cpp -fsycl-targets=nvptx64-nvidia-cuda
  2. Specify the command which should be used to launch the program
    ./a.out
  3. Indicate what is wrong
    Output has error:
An error has occurred!

Environment

  • OS: Linux
  • Target device and vendor: [cuda:gpu][cuda:0] NVIDIA CUDA BACKEND, NVIDIA GeForce RTX 2060 7.5 [CUDA 12.6]
  • DPC++ version: clang version 20.0.0git (https://github.com/intel/llvm a78cf31)
@wenju-he wenju-he added the bug Something isn't working label Oct 11, 2024
@wenju-he
Copy link
Contributor Author

@intel/bindless-images-reviewers could you please take a look?

@Seanst98 Seanst98 added the sycl-bindless-images SYCL Bindless Images label Oct 11, 2024
@ProGTX
Copy link
Contributor

ProGTX commented Oct 11, 2024

We're looking into this internally. We've noticed issues with this test in the past - there might be an issue with rounding on different devices.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working sycl-bindless-images SYCL Bindless Images
Projects
None yet
Development

No branches or pull requests

3 participants