Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESIMD] assert test fails after GPU driver uplift #11359

Open
AlexeySachkov opened this issue Sep 29, 2023 · 1 comment
Open

[ESIMD] assert test fails after GPU driver uplift #11359

AlexeySachkov opened this issue Sep 29, 2023 · 1 comment
Labels
bug Something isn't working confirmed esimd Explicit SIMD feature

Comments

@AlexeySachkov
Copy link
Contributor

Describe the bug

The test contains a driver version check and it was expected to pass with a newer GPU driver. However, pre-commit results in #11302 show that it is not the case.

To Reproduce

Install NEO 23.30.26918.9, launch the test using any existing mechanism for that (check-sycl-e2e target or just repeating commands manually)

Environment (please complete the following information):

  • OS: Linux
  • Target device and vendor: Intel GPU
  • DPC++ version: any recent intel/llvm will do
  • Dependencies version: NEO 23.30.26918.9
    Additional context

Attaching full log here:

********************
FAIL: SYCL :: ESIMD/assert.cpp ([501](https://github.com/intel/llvm/actions/runs/6307558002/job/17125034057#step:21:502) of 1712)
******************** TEST 'SYCL :: ESIMD/assert.cpp' FAILED ********************
Script:
--
: 'RUN: at line 3';    /__w/llvm/llvm/toolchain/bin//clang++   -fsycl -fsycl-targets=spir64 /__w/llvm/llvm/llvm/sycl/test-e2e/ESIMD/assert.cpp -DSYCL_FALLBACK_ASSERT=1 -o /__w/llvm/llvm/build-e2e/ESIMD/Output/assert.cpp.tmp.out
: 'RUN: at line 4';   env ONEAPI_DEVICE_SELECTOR=ext_oneapi_level_zero:gpu  /__w/llvm/llvm/build-e2e/ESIMD/Output/assert.cpp.tmp.out &> /__w/llvm/llvm/build-e2e/ESIMD/Output/assert.cpp.tmp.txt ; /__w/llvm/llvm/toolchain/bin/FileCheck /__w/llvm/llvm/llvm/sycl/test-e2e/ESIMD/assert.cpp --input-file /__w/llvm/llvm/build-e2e/ESIMD/Output/assert.cpp.tmp.txt
--
Exit Code: 1

Command Output (stdout):
--
$ ":" "RUN: at line 3"
note: command had no output on stdout or stderr
$ "/__w/llvm/llvm/toolchain/bin//clang++" "-fsycl" "-fsycl-targets=spir64" "/__w/llvm/llvm/llvm/sycl/test-e2e/ESIMD/assert.cpp" "-DSYCL_FALLBACK_ASSERT=1" "-o" "/__w/llvm/llvm/build-e2e/ESIMD/Output/assert.cpp.tmp.out"
# command stderr:
In file included from /__w/llvm/llvm/llvm/sycl/test-e2e/ESIMD/assert.cpp:6:
/__w/llvm/llvm/llvm/sycl/test-e2e/ESIMD/esimd_test_utils.hpp:40:40: warning: 'ext_intel_esimd_emulator' is deprecated: esimd emulator is no longer supported [-Wdeprecated-declarations]
   40 |   if (device.get_backend() == backend::ext_intel_esimd_emulator) {
      |                                        ^
/__w/llvm/llvm/toolchain/bin/../include/sycl/backend_types.hpp:24:28: note: 'ext_intel_esimd_emulator' has been explicitly marked deprecated here
   24 |   ext_intel_esimd_emulator __SYCL_DEPRECATED(
      |                            ^
/__w/llvm/llvm/toolchain/bin/../include/sycl/detail/defines_elementary.hpp:44:38: note: expanded from macro '__SYCL_DEPRECATED'
   44 | #define __SYCL_DEPRECATED(message) [[deprecated(message)]]
      |                                      ^
1 warning generated.
In file included from /__w/llvm/llvm/llvm/sycl/test-e2e/ESIMD/assert.cpp:6:
/__w/llvm/llvm/llvm/sycl/test-e2e/ESIMD/esimd_test_utils.hpp:40:40: warning: 'ext_intel_esimd_emulator' is deprecated: esimd emulator is no longer supported [-Wdeprecated-declarations]
   40 |   if (device.get_backend() == backend::ext_intel_esimd_emulator) {
      |                                        ^
/__w/llvm/llvm/toolchain/bin/../include/sycl/backend_types.hpp:24:28: note: 'ext_intel_esimd_emulator' has been explicitly marked deprecated here
   24 |   ext_intel_esimd_emulator __SYCL_DEPRECATED(
      |                            ^
/__w/llvm/llvm/toolchain/bin/../include/sycl/detail/defines_elementary.hpp:44:38: note: expanded from macro '__SYCL_DEPRECATED'
   44 | #define __SYCL_DEPRECATED(message) [[deprecated(message)]]
      |                                      ^
1 warning generated.

$ ":" "RUN: at line 4"
note: command had no output on stdout or stderr
$ "env" "ONEAPI_DEVICE_SELECTOR=ext_oneapi_level_zero:gpu" "/__w/llvm/llvm/build-e2e/ESIMD/Output/assert.cpp.tmp.out"
note: command had no output on stdout or stderr
$ "/__w/llvm/llvm/toolchain/bin/FileCheck" "/__w/llvm/llvm/llvm/sycl/test-e2e/ESIMD/assert.cpp" "--input-file" "/__w/llvm/llvm/build-e2e/ESIMD/Output/assert.cpp.tmp.txt"
# command stderr:
/__w/llvm/llvm/llvm/sycl/test-e2e/ESIMD/assert.cpp:30:12: error: CHECK: expected string not found in input
 // CHECK: Assert called: Id != 31 && "assert message31"
           ^
/__w/llvm/llvm/build-e2e/ESIMD/Output/assert.cpp.tmp.txt:1:1: note: scanning from here
Running on Intel(R) Iris(R) Xe Graphics, driver=[1.3.26918]
^
/__w/llvm/llvm/build-e2e/ESIMD/Output/assert.cpp.tmp.txt:1:22: note: possible intended match here
Running on Intel(R) Iris(R) Xe Graphics, driver=[1.3.26918]
                     ^

Input file: /__w/llvm/llvm/build-e2e/ESIMD/Output/assert.cpp.tmp.txt
Check file: /__w/llvm/llvm/llvm/sycl/test-e2e/ESIMD/assert.cpp

-dump-input=help explains the following input dump.

Input was:
<<<<<<
            1: Running on Intel(R) Iris(R) Xe Graphics, driver=[1.3.26918] 
check:30'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
check:30'1                          ?                                       possible intended match
            2: Test finished 
check:30'0     ~~~~~~~~~~~~~~
>>>>>>

error: command failed with exit status: 1

Corresponding pre-commit run: https://github.com/intel/llvm/actions/runs/6307558002/job/17125034057

The test will be temporary XFAIL-ed on Linux in #11302 to proceed with GPU driver uplift. Since the feature has only been recently enabled (#9615) and it wasn't supposed to work with older GPU drivers, this is not a regression and therefore such temporary disabling is considered acceptable.

@sarnex
Copy link
Contributor

sarnex commented Aug 1, 2024

Fixed in recent IGC but not released yet, waiting for driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working confirmed esimd Explicit SIMD feature
Projects
None yet
Development

No branches or pull requests

2 participants