Skip to content

Commit f0d9512

Browse files
committed
Tweak wording of decorations in SPIR-V spec
This addresses comments from the FPGA team.
1 parent 5d15892 commit f0d9512

File tree

1 file changed

+19
-12
lines changed

1 file changed

+19
-12
lines changed

sycl/doc/extensions/DeviceGlobal/SPV_INTEL_global_variable_decorations.asciidoc

Lines changed: 19 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -121,17 +121,14 @@ API's execution environment may use to identify this variable.
121121
Legal values of _Access_:
122122

123123
* 0 [Read] - The execution environment may read the variable from the host but
124-
will never write it. On an FPGA device, only a read memory port is exposed
125-
by the generated IP core.
124+
will never write it. On an FPGA device, only a read memory port is exposed.
126125
* 1 [Write] - The execution environment may write the variable from the host
127126
but will never read it. On an FPGA device, only a write memory port is
128-
exposed by the generated IP core.
127+
exposed.
129128
* 2 [Read/Write] - The execution environment may read or write the variable
130-
from the host. On an FPGA device, a read/write memory port is exposed by the
131-
generated IP core.
129+
from the host. On an FPGA device, a read/write memory port is exposed.
132130
* 3 [None] - The execution environment may neither read nor write the variable
133-
from the host. On an FPGA device, no memory port is exposed by the generated
134-
IP core.
131+
from the host. On an FPGA device, no memory port is exposed.
135132

136133
If a global *OpVariable* is not decorated with *HostAccessINTEL*, the default
137134
behavior is [Read/Write].
@@ -145,18 +142,25 @@ _Name_
145142
| 6148
146143
a|
147144
*InitModeINTEL* +
148-
Only valid on global (module scope) *OpVariable*.
145+
Only valid on global (module scope) *OpVariable* which has an _Initializer_
146+
operand.
149147

150148
This decoration only has an effect when the consumer is an FPGA or similar
151149
device. The _Trigger_ value tells how the global variable should be
152150
initialized.
153151

154152
Legal values of _Trigger_:
155153

156-
* 0 [init on device reprogram] - Initialization is performed when the device is
157-
programmed.
158-
* 1 [init on device reset] - Initialization is performed when a reset signal is
159-
sent to the device.
154+
* 0 [init on device reprogram] - Initialization is performed by reprogramming
155+
the device. This may require more frequent reprogramming but may reduce
156+
area.
157+
* 1 [init on device reset] - Initialization is performed by sending a reset
158+
signal to the device. This may increase area but may reduce reprogramming
159+
frequency.
160+
161+
If a global *OpVariable* with an _Initializer_ operand is not decorated with
162+
*InitModeINTEL*, the method by which its value is initialized is implementation
163+
defined.
160164

161165
2+| Literal Number +
162166
_Trigger_
@@ -178,6 +182,9 @@ Legal values of _Value_:
178182
* 1 [True] - Access to this memory is through a CSR interface shared with the
179183
kernel arguments.
180184

185+
If a global *OpVariable* is not decorated with *ImplementInCSRINTEL*, the
186+
interface for the variable is implementation defined.
187+
181188
2+| Literal Number +
182189
_Value_
183190
| *GlobalVariableDecorationsINTEL*

0 commit comments

Comments
 (0)