Skip to content

Commit eb214a1

Browse files
committed
reviewer feedback
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
1 parent 7e6b1f9 commit eb214a1

File tree

11 files changed

+3
-19
lines changed

11 files changed

+3
-19
lines changed

sycl/include/CL/sycl/group_algorithm.hpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@
1010
#include <CL/__spirv/spirv_ops.hpp>
1111
#include <CL/__spirv/spirv_types.hpp>
1212
#include <CL/__spirv/spirv_vars.hpp>
13-
#include <CL/sycl/ONEAPI/atomic.hpp>
1413
#include <CL/sycl/ONEAPI/functional.hpp>
1514
#include <CL/sycl/detail/spirv.hpp>
1615
#include <CL/sycl/detail/type_traits.hpp>

sycl/include/CL/sycl/known_identity.hpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,9 @@
99
#pragma once
1010

1111
#include <CL/sycl/detail/type_traits.hpp>
12+
#include <functional>
13+
#include <limits>
14+
#include <type_traits>
1215

1316
__SYCL_INLINE_NAMESPACE(cl) {
1417
namespace sycl {

sycl/test/on-device/group_algorithms_sycl2020/all_of.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -I . -o %t.out
2-
// TODO: re-enable HOST execution line when this test is moved to
3-
// llvm-test-suite XUN: %HOST_RUN_PLACEHOLDER %t.out
42
// RUN: %CPU_RUN_PLACEHOLDER %t.out
53
// RUN: %GPU_RUN_PLACEHOLDER %t.out
64
// RUN: %ACC_RUN_PLACEHOLDER %t.out

sycl/test/on-device/group_algorithms_sycl2020/any_of.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -I . -o %t.out
2-
// TODO: re-enable HOST execution line when this test is moved to
3-
// llvm-test-suite XUN: %HOST_RUN_PLACEHOLDER %t.out
42
// RUN: %CPU_RUN_PLACEHOLDER %t.out
53
// RUN: %GPU_RUN_PLACEHOLDER %t.out
64
// RUN: %ACC_RUN_PLACEHOLDER %t.out

sycl/test/on-device/group_algorithms_sycl2020/exclusive_scan.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -I . -o %t.out
2-
// TODO: re-enable HOST execution line when this test is moved to
3-
// llvm-test-suite XUN: %HOST_RUN_PLACEHOLDER %t.out
42
// RUN: %CPU_RUN_PLACEHOLDER %t.out
53
// RUN: %GPU_RUN_PLACEHOLDER %t.out
64
// RUN: %ACC_RUN_PLACEHOLDER %t.out

sycl/test/on-device/group_algorithms_sycl2020/group_broadcast.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
2-
// TODO: re-enable HOST execution line when this test is moved to
3-
// llvm-test-suite XUN: %HOST_RUN_PLACEHOLDER %t.out
42
// RUN: %CPU_RUN_PLACEHOLDER %t.out
53
// RUN: %GPU_RUN_PLACEHOLDER %t.out
64
// RUN: %ACC_RUN_PLACEHOLDER %t.out

sycl/test/on-device/group_algorithms_sycl2020/inclusive_scan.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -I . -o %t.out
2-
// TODO: re-enable HOST execution line when this test is moved to
3-
// llvm-test-suite XUN: %HOST_RUN_PLACEHOLDER %t.out
42
// RUN: %CPU_RUN_PLACEHOLDER %t.out
53
// RUN: %GPU_RUN_PLACEHOLDER %t.out
64
// RUN: %ACC_RUN_PLACEHOLDER %t.out

sycl/test/on-device/group_algorithms_sycl2020/none_of.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -I . -o %t.out
2-
// TODO: re-enable HOST execution line when this test is moved to
3-
// llvm-test-suite XUN: %HOST_RUN_PLACEHOLDER %t.out
42
// RUN: %CPU_RUN_PLACEHOLDER %t.out
53
// RUN: %GPU_RUN_PLACEHOLDER %t.out
64
// RUN: %ACC_RUN_PLACEHOLDER %t.out

sycl/test/on-device/group_algorithms_sycl2020/permute_select.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
2-
// TODO: re-enable HOST execution line when this test is moved to
3-
// llvm-test-suite XUN: %HOST_RUN_PLACEHOLDER %t.out
42
// RUN: %CPU_RUN_PLACEHOLDER %t.out
53
// RUN: %GPU_RUN_PLACEHOLDER %t.out
64
// RUN: %ACC_RUN_PLACEHOLDER %t.out

sycl/test/on-device/group_algorithms_sycl2020/reduce.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -I . -o %t.out
2-
// TODO: re-enable HOST execution line when this test is moved to
3-
// llvm-test-suite XUN: %HOST_RUN_PLACEHOLDER %t.out
42
// RUN: %CPU_RUN_PLACEHOLDER %t.out
53
// RUN: %GPU_RUN_PLACEHOLDER %t.out
64
// RUN: %ACC_RUN_PLACEHOLDER %t.out

sycl/test/on-device/group_algorithms_sycl2020/shift_left_right.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,4 @@
11
// RUN: %clangxx -fsycl -fsycl-targets=%sycl_triple %s -o %t.out
2-
// TODO: re-enable HOST execution line when this test is moved to
3-
// llvm-test-suite XUN: %HOST_RUN_PLACEHOLDER %t.out
42
// RUN: %CPU_RUN_PLACEHOLDER %t.out
53
// RUN: %GPU_RUN_PLACEHOLDER %t.out
64
// RUN: %ACC_RUN_PLACEHOLDER %t.out

0 commit comments

Comments
 (0)