Skip to content

Commit eadb31c

Browse files
author
Pavel Chupin
authored
Revert "[LIBCLC] Generate FunctionDecl to remangle substituted entries (#7220)"
This reverts commit 114aeba.
1 parent 791057e commit eadb31c

File tree

4 files changed

+455
-775
lines changed

4 files changed

+455
-775
lines changed

libclc/cmake/modules/AddLibclc.cmake

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -108,9 +108,6 @@ macro(add_libclc_builtin_set arch_suffix)
108108

109109
# Generate remangled variants if requested
110110
if( LIBCLC_GENERATE_REMANGLED_VARIANTS )
111-
set(dummy_in "${CMAKE_BINARY_DIR}/lib/clc/libclc_dummy_in.cc")
112-
add_custom_command( OUTPUT ${dummy_in}
113-
COMMAND ${CMAKE_COMMAND} -E touch ${dummy_in} )
114111
set(long_widths l32 l64)
115112
set(char_signedness signed unsigned)
116113
if( ${obj_suffix} STREQUAL "libspirv-nvptx64--nvidiacl.bc")
@@ -131,11 +128,10 @@ macro(add_libclc_builtin_set arch_suffix)
131128
-o "${builtins_remangle_path}"
132129
--long-width=${long_width}
133130
--char-signedness=${signedness}
134-
--input-ir="$<TARGET_PROPERTY:prepare-${obj_suffix},TARGET_FILE>"
135-
${dummy_in}
136-
DEPENDS "${builtins_obj_path}" "prepare-${obj_suffix}" libclc-remangler ${dummy_in})
131+
"$<TARGET_PROPERTY:prepare-${obj_suffix},TARGET_FILE>"
132+
DEPENDS "${builtins_obj_path}" "prepare-${obj_suffix}" libclc-remangler )
137133
add_custom_target( "remangled-${long_width}-${signedness}_char.${obj_suffix_mangled}" ALL
138-
DEPENDS "${builtins_remangle_path}" "${dummy_in}")
134+
DEPENDS "${builtins_remangle_path}" )
139135
set_target_properties("remangled-${long_width}-${signedness}_char.${obj_suffix_mangled}"
140136
PROPERTIES TARGET_FILE "${builtins_remangle_path}")
141137

libclc/test/CMakeLists.txt

Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -43,27 +43,3 @@ foreach( t ${LIBCLC_TARGET_TO_TEST} )
4343

4444
endforeach( d )
4545
endforeach( t )
46-
47-
if(LIBCLC_GENERATE_REMANGLED_VARIANTS)
48-
# Run remangler in test mode if generating remangled variants and make sure
49-
# it depends on check-libclc target.
50-
# Both `long_widths` and `char_signedness` are set in AddLibclc.cmake and can
51-
# be used here.
52-
foreach(long_width ${long_widths})
53-
foreach(signedness ${char_signedness})
54-
# In `-t` (TestRun) the remangler does not perform any substitutions, it
55-
# needs to make sure that the remangled name matches the original mangled
56-
# one.
57-
set (test_target_name "test-remangled-${long_width}-${signedness}_char")
58-
add_custom_target(${test_target_name}
59-
COMMAND libclc-remangler
60-
--long-width=${long_width}
61-
--char-signedness=${signedness}
62-
--input-ir="$<TARGET_PROPERTY:prepare-${obj_suffix},TARGET_FILE>"
63-
${dummy_in} -t -o -
64-
DEPENDS "${builtins_obj_path}" "prepare-${obj_suffix}" "${dummy_in}" libclc-remangler)
65-
66-
add_dependencies(check-libclc ${test_target_name})
67-
endforeach()
68-
endforeach()
69-
endif()

libclc/utils/libclc-remangler/CMakeLists.txt

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,4 @@ target_include_directories(libclc-remangler PRIVATE
1414
${CMAKE_SOURCE_DIR}/../clang/include
1515
${CMAKE_BINARY_DIR}/tools/clang/include)
1616

17-
clang_target_link_libraries(libclc-remangler
18-
PRIVATE
19-
clangAST
20-
clangBasic
21-
clangFrontend
22-
clangTooling
23-
LLVMOption
24-
)
17+
clang_target_link_libraries(libclc-remangler PRIVATE clangBasic)

0 commit comments

Comments
 (0)