Skip to content

Commit d824127

Browse files
[SYCL] missing SYCL_EXPORT leading to downstream troubles (#7318)
my earlier post-commit fix caused an ABI symbols problem downstream. But the original problem is that the custom specialization of `get_info<parent_device>` is merely missing an export declaration. If I'm right, or just dumb lucky, then this will fix all downstream failures, including post-commit. And if not, well, the symbol update is correct regardless Signed-off-by: Chris Perkins <chris.perkins@intel.com>
1 parent cda6680 commit d824127

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

sycl/source/device.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,8 @@ device::get_info() const {
128128
}
129129

130130
// Explicit override. Not fulfilled by #include device_traits.def below.
131-
template <> device device::get_info<info::device::parent_device>() const {
131+
template <>
132+
__SYCL_EXPORT device device::get_info<info::device::parent_device>() const {
132133
// With ONEAPI_DEVICE_SELECTOR the impl.MRootDevice is preset and may be
133134
// overridden (ie it may be nullptr on a sub-device) The PI of the sub-devices
134135
// have parents, but we don't want to return them. They must pretend to be

0 commit comments

Comments
 (0)