Skip to content

Commit bf82cfa

Browse files
[SYCL][E2E] Remove UB kernel launch in sycl_join (#18288)
This commit removes the explicit kernel launch in sycl_join, as the use of the set_args assumes the layout of arguments in the kernel, which is not guaranteed to be as expected. Signed-off-by: Larsen, Steffen <steffen.larsen@intel.com>
1 parent 54e9012 commit bf82cfa

File tree

1 file changed

+3
-16
lines changed

1 file changed

+3
-16
lines changed

sycl/test-e2e/KernelCompiler/sycl_join.cpp

Lines changed: 3 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -210,25 +210,12 @@ int main() {
210210
++Failed;
211211
}
212212

213-
Q.submit([&](sycl::handler &CGH) {
214-
CGH.set_args(IntPtr);
215-
CGH.single_task(RegularSYCLK);
216-
}).wait_and_throw();
217-
218-
if (*IntPtr != RegularSYCLKernelWriteValue) {
219-
std::cout << "Regular SYCL kernel (explicit) in joined mixed executable "
220-
"bundles failed: "
221-
<< *IntPtr << " != " << RegularSYCLKernelWriteValue << "\n";
222-
++Failed;
223-
}
224-
*IntPtr = 0;
225-
226213
RunRegularSYCLKernel(Q, KBExeJoined, IntPtr);
227214

228215
if (*IntPtr != RegularSYCLKernelWriteValue) {
229-
std::cout << "Regular SYCL kernel (implicit) in joined mixed executable "
230-
"bundles failed: "
231-
<< *IntPtr << " != " << RegularSYCLKernelWriteValue << "\n";
216+
std::cout
217+
<< "Regular SYCL kernel in joined mixed executable bundles failed: "
218+
<< *IntPtr << " != " << RegularSYCLKernelWriteValue << "\n";
232219
++Failed;
233220
}
234221

0 commit comments

Comments
 (0)