Apply comments

Author: AlexeySachkov

clang/include/clang/Basic/DiagnosticFrontendKinds.td

@@ -314,8 +314,8 @@ def warn_profile_data_unprofiled : Warning<
 } // end of instrumentation issue category
 
 def warn_sycl_wrong_aspect_usage : Warning<
-  "function '%0' uses aspect '%1' not listed in `sycl::device_has()`">,
-  InGroup<SyclAspectUsage>;
+  "function '%0' uses aspect '%1' not listed in 'sycl::device_has()'">,
+  InGroup<DiagGroup<"sycl-aspect-usage">>;
 def note_sycl_wrong_aspect_usage : Note<
   "%select{the actual use is in|which is called by}0 "
   "%1%select{|, compile with '-g' to get source location}2">;

clang/include/clang/Basic/DiagnosticGroups.td

@@ -1239,7 +1239,6 @@ def Sycl2020Compat : DiagGroup<"sycl-2020-compat">;
 def SyclStrict : DiagGroup<"sycl-strict", [ Sycl2017Compat, Sycl2020Compat]>;
 def SyclTarget : DiagGroup<"sycl-target">;
 def SyclFPGAMismatch : DiagGroup<"sycl-fpga-mismatch">;
-def SyclAspectUsage : DiagGroup<"sycl-aspect-usage">;
 
 // Backend warnings.
 def BackendInlineAsm : DiagGroup<"inline-asm">;

sycl/test/basic_tests/aspect_usage.cpp

@@ -13,12 +13,12 @@
 
 // RUN: %clangxx -fsycl %s -g -emit-llvm -S -o /dev/null 2>&1 | FileCheck %s --check-prefix CHECK-WARNINGS-DBG -DPATH=%s
 
-// CHECK-WARNINGS: warning: function 'func1(int)' uses aspect 'fp16' not listed in `sycl::device_has()`
+// CHECK-WARNINGS: warning: function 'func1(int)' uses aspect 'fp16' not listed in 'sycl::device_has()'
 // CHECK-WARNINGS-NEXT: note: the actual use is in func3(int, int, int), compile with '-g' to get source location
 // CHECK-WARNINGS-NEXT: note: which is called by func2(int, int), compile with '-g' to get source location
 // CHECK-WARNINGS-NEXT: note: which is called by func1(int), compile with '-g' to get source location
 //
-// CHECK-WARNINGS-DBG: warning: function 'func1(int)' uses aspect 'fp16' not listed in `sycl::device_has()`
+// CHECK-WARNINGS-DBG: warning: function 'func1(int)' uses aspect 'fp16' not listed in 'sycl::device_has()'
 // CHECK-WARNINGS-DBG-NEXT: note: the actual use is in func3(int, int, int) at [[PATH]]:36:5
 // CHECK-WARNINGS-DBG-NEXT: note: which is called by func2(int, int) at [[PATH]]:40:34
 // CHECK-WARNINGS-DBG-NEXT: note: which is called by func1(int) at [[PATH]]:42:62