[SYCL] Fix forward declaration in integration header (#9087)

Do not emit 'final' keyword on forward declaration of classes in
integration header.

Author: elizabethandrews

clang/include/clang/AST/PrettyPrinter.h

@@ -64,10 +64,11 @@ struct PrintingPolicy {
         ConstantArraySizeAsWritten(false), AnonymousTagLocations(true),
         SuppressStrongLifetime(false), SuppressLifetimeQualifiers(false),
         SuppressTypedefs(false), SuppressTemplateArgsInCXXConstructors(false),
-        SuppressDefaultTemplateArgs(true), Bool(LO.Bool),
-        Nullptr(LO.CPlusPlus11 || LO.C2x), NullptrTypeInNamespace(LO.CPlusPlus),
-        Restrict(LO.C99), Alignof(LO.CPlusPlus11),
-        UnderscoreAlignof(LO.C11), UseVoidForZeroParams(!LO.CPlusPlus),
+        SuppressDefaultTemplateArgs(true), SuppressFinalSpecifier(false),
+        Bool(LO.Bool), Nullptr(LO.CPlusPlus11 || LO.C2x),
+        NullptrTypeInNamespace(LO.CPlusPlus), Restrict(LO.C99),
+        Alignof(LO.CPlusPlus11), UnderscoreAlignof(LO.C11),
+        UseVoidForZeroParams(!LO.CPlusPlus),
         SplitTemplateClosers(!LO.CPlusPlus11), TerseOutput(false),
         PolishForDeclaration(false), Half(LO.Half),
         MSWChar(LO.MicrosoftExt && !LO.WChar), IncludeNewlines(true),
@@ -214,6 +215,9 @@ struct PrintingPolicy {
   /// argument for the parameter.
   unsigned SuppressDefaultTemplateArgs : 1;
 
+  /// When true, suppress printing final specifier.
+  unsigned SuppressFinalSpecifier : 1;
+
   /// Whether we can use 'bool' rather than '_Bool' (even if the language
   /// doesn't actually have 'bool', because, e.g., it is defined as a macro).
   unsigned Bool : 1;

clang/lib/AST/DeclPrinter.cpp

@@ -1017,7 +1017,7 @@ void DeclPrinter::VisitCXXRecordDecl(CXXRecordDecl *D) {
     }
   }
 
-  if (D->hasDefinition()) {
+  if (D->hasDefinition() && !Policy.SuppressFinalSpecifier) {
     if (D->hasAttr<FinalAttr>()) {
       Out << " final";
     }

clang/lib/Sema/SemaSYCL.cpp

@@ -4889,6 +4889,7 @@ class SYCLFwdDeclEmitter
     Policy.SuppressUnwrittenScope = true;
     Policy.PrintCanonicalTypes = true;
     Policy.SkipCanonicalizationOfTemplateTypeParms = true;
+    Policy.SuppressFinalSpecifier = true;
   }
 
   void Visit(QualType T) {

clang/test/CodeGenSYCL/integration_header.cpp

@@ -3,6 +3,7 @@
 //
 // CHECK: #include <sycl/detail/kernel_desc.hpp>
 //
+// CHECK: // Forward declarations of templated kernel function types:
 // CHECK: class first_kernel;
 // CHECK-NEXT: namespace second_namespace {
 // CHECK-NEXT: template <typename T> class second_kernel;
@@ -11,6 +12,7 @@
 // CHECK-NEXT: template <int DimX> struct namespaced_arg;
 // CHECK-NEXT: }
 // CHECK-NEXT: template <typename ...Ts> class fourth_kernel;
+// CHECK: class FinalClass;
 //
 // CHECK: static constexpr
 // CHECK-NEXT: const char* const kernel_names[] = {
@@ -19,6 +21,7 @@
 // CHECK-NEXT:   "_ZTS13fourth_kernelIJN15template_arg_ns14namespaced_argILi1EEEEE"
 // CHECK-NEXT:   "_ZTSZ4mainE16accessor_in_base"
 // CHECK-NEXT:   "_ZTSZ4mainE15annotated_types"
+// CHECK-NEXT:   "_ZTS10FinalClass"
 // CHECK-NEXT: };
 //
 // CHECK: static constexpr
@@ -54,6 +57,8 @@
 // CHECK-NEXT:  { kernel_param_kind_t::kind_pointer, 8, 8 },
 // CHECK-NEXT:  { kernel_param_kind_t::kind_pointer, 8, 16 },
 // CHECK-EMPTY:
+// CHECK-NEXT:  //--- _ZTS10FinalClass
+// CHECK-EMPTY:
 // CHECK-NEXT:  { kernel_param_kind_t::kind_invalid, -987654321, -987654321 },
 // CHECK-NEXT: };
 //
@@ -110,6 +115,8 @@ struct captured : base, base2 {
 
 struct MockProperty {};
 
+class FinalClass final {};
+
 int main() {
 
   sycl::accessor<char, 1, sycl::access::mode::read> acc1;
@@ -160,5 +167,7 @@ int main() {
     (void)AP3;
   });
 
+  kernel_single_task<class FinalClass>([=]() { });
+
   return 0;
 }