[SYCL] Fixed memory leaks in SchedulerTest.LeafLimit test

Author: DenisBakhvalov

sycl/unittests/scheduler/LeafLimit.cpp

@@ -21,11 +21,14 @@ using namespace cl::sycl;
 // overflowed.
 TEST_F(SchedulerTest, LeafLimit) {
   MockScheduler MS;
+  std::vector<std::unique_ptr<MockCommand>> LeavesToAdd;
+  std::unique_ptr<MockCommand> MockDepCmd;
 
   buffer<int, 1> Buf(range<1>(1));
   detail::Requirement MockReq = getMockRequirement(Buf);
-  MockCommand *MockDepCmd =
-      new MockCommand(detail::getSyclObjImpl(MQueue), MockReq);
+
+  MockDepCmd =
+      std::make_unique<MockCommand>(detail::getSyclObjImpl(MQueue), MockReq);
   detail::MemObjRecord *Rec =
       MS.getOrInsertMemObjRecord(detail::getSyclObjImpl(MQueue), &MockReq);
 
@@ -34,16 +37,17 @@ TEST_F(SchedulerTest, LeafLimit) {
   for (std::size_t i = 0; i < Rec->MWriteLeaves.genericCommandsCapacity() + 1;
        ++i) {
     LeavesToAdd.push_back(
-        new MockCommand(detail::getSyclObjImpl(MQueue), MockReq));
+        std::make_unique<MockCommand>(detail::getSyclObjImpl(MQueue), MockReq));
   }
   // Create edges: all soon-to-be leaves are direct users of MockDep
-  for (auto Leaf : LeavesToAdd) {
-    MockDepCmd->addUser(Leaf);
-    Leaf->addDep(detail::DepDesc{MockDepCmd, Leaf->getRequirement(), nullptr});
+  for (auto &Leaf : LeavesToAdd) {
+    MockDepCmd->addUser(Leaf.get());
+    Leaf->addDep(
+        detail::DepDesc{MockDepCmd.get(), Leaf->getRequirement(), nullptr});
   }
   // Add edges as leaves and exceed the leaf limit
-  for (auto LeafPtr : LeavesToAdd) {
-    MS.addNodeToLeaves(Rec, LeafPtr);
+  for (auto &LeafPtr : LeavesToAdd) {
+    MS.addNodeToLeaves(Rec, LeafPtr.get());
   }
   // Check that the oldest leaf has been removed from the leaf list
   // and added as a dependency of the newest one instead
@@ -52,11 +56,11 @@ TEST_F(SchedulerTest, LeafLimit) {
   ASSERT_TRUE(std::find(Leaves.begin(), Leaves.end(), LeavesToAdd.front()) ==
               Leaves.end());
   for (std::size_t i = 1; i < LeavesToAdd.size(); ++i) {
-    assert(std::find(Leaves.begin(), Leaves.end(), LeavesToAdd[i]) !=
+    assert(std::find(Leaves.begin(), Leaves.end(), LeavesToAdd[i].get()) !=
            Leaves.end());
   }
-  MockCommand *OldestLeaf = LeavesToAdd.front();
-  MockCommand *NewestLeaf = LeavesToAdd.back();
+  MockCommand *OldestLeaf = LeavesToAdd.front().get();
+  MockCommand *NewestLeaf = LeavesToAdd.back().get();
   ASSERT_EQ(OldestLeaf->MUsers.size(), 1U);
   EXPECT_GT(OldestLeaf->MUsers.count(NewestLeaf), 0U);
   ASSERT_EQ(NewestLeaf->MDeps.size(), 2U);