Skip to content

Commit

Permalink
Remove redundant section from GSG
Browse files Browse the repository at this point in the history
  • Loading branch information
srividya-sundaram committed Feb 1, 2021
1 parent edffe2f commit 7d944bf
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 37 deletions.
2 changes: 0 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,8 +111,6 @@ pull request should be created under
[KhronosGroup/SYCL-CTS](https://github.com/KhronosGroup/SYCL-CTS) with required
patch.
### Commit message
- When writing your commit message, please make sure to follow
Expand Down
35 changes: 0 additions & 35 deletions sycl/doc/GetStartedGuide.md
Original file line number Diff line number Diff line change
Expand Up @@ -333,41 +333,6 @@ Make sure that these binaries are available in `PATH` environment variable:
* `aoc` from `<oneAPI installation location>/compiler/<version>/<OS>/lib/oclfpga/bin`
* `aocl-ioc64` from `<oneAPI installation location>/compiler/<version>/<OS>/bin`
### Test DPC++ toolchain
Every product change should be accompanied with corresponding test modification
(adding new test(s), extending, removing or modifying existing test(s)).
There are 3 types of tests which are used for DPC++ toolchain validation:
* DPC++ in-tree LIT tests including [check-llvm](../../llvm/test),
[check-clang](../../clang/test), [check-llvm-spirv](../../llvm-spirv/test) and
[check-sycl](../../sycl/test) targets stored in this repository. These tests
should not have hardware (e.g. GPU, FPGA, etc.) or external software
dependencies (e.g. OpenCL, Level Zero, CUDA runtimes). All tests not following
this approach should be moved to DPC++ end-to-end or SYCL-CTS tests.
However, the tests for a feature under active development requiring atomic
change for tests and product can be put to
[sycl/test/on-device](../../sycl/test/on-device) temporarily. It is developer
responsibility to move the tests to DPC++ E2E test suite or SYCL-CTS once
the feature is stabilized.
* DPC++ end-to-end (E2E) tests which are extension to
[LLVM\* test suite](https://github.com/intel/llvm-test-suite/tree/intel/SYCL).
A test which requires full stack including backend runtimes (e.g. OpenCL,
Level Zero or CUDA) should be put to DPC++ E2E test suite following
[CONTRIBUTING](https://github.com/intel/llvm-test-suite/blob/intel/CONTRIBUTING.md).
* SYCL-CTS are official
[Khronos\* SYCL\* conformance tests](https://github.com/KhronosGroup/SYCL-CTS).
They verify SYCL specification compatibility. All implementation details or
extensions are out of scope for the tests. If SYCL specification has changed
(SYCL CTS tests conflict with recent version of SYCL specification) or change
is required in the way the tests are built with DPC++ compiler (defined in
[FindIntel_SYCL](https://github.com/KhronosGroup/SYCL-CTS/blob/SYCL-1.2.1/master/cmake/FindIntel_SYCL.cmake))
pull request should be created under
[KhronosGroup/SYCL-CTS](https://github.com/KhronosGroup/SYCL-CTS) with required
patch.
#### Run in-tree LIT tests
To verify that built DPC++ toolchain is working correctly, run:
Expand Down

0 comments on commit 7d944bf

Please sign in to comment.