Skip to content

Commit 4f31cad

Browse files
committed
[NFC] Update src test to be more clear, amend comment
Signed-off-by: Michael D Toguchi <michael.d.toguchi@intel.com>
1 parent 90cee29 commit 4f31cad

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

clang/lib/Driver/Driver.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3717,8 +3717,11 @@ class OffloadingActionBuilder final {
37173717
continue;
37183718
}
37193719
// We want to move the AOCX/AOCR binary to the front of the objects
3720-
// allowing it to be picked up before the other device objects at
3721-
// runtime.
3720+
// allowing it to be picked up instead of the other device objects
3721+
// at runtime.
3722+
// TODO: In the presense of existing FPGA Device binaries (AOCX)
3723+
// we do not need to perform/add the SPIR-V generated device
3724+
// binaries from sources or objects.
37223725
if (types::isFPGA(I->getType())) {
37233726
// Do not perform a device link and only pass the aocr
37243727
// file to the offline compilation before wrapping. Just

clang/test/Driver/sycl-offload-intelfpga.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,8 @@
153153
// CHK-FPGA-AOCX-SRC: clang-offload-bundler{{.*}} "-type=ao" "-targets=sycl-fpga_aocx-intel-unknown-sycldevice" "-inputs=[[LIBINPUT:.+\.a]]" "-outputs=[[BUNDLEOUT:.+\.aocx]]" "-unbundle"
154154
// CHK-FPGA-AOCX-SRC: clang-offload-wrapper{{.*}} "-o=[[WRAPOUT:.+\.bc]]" {{.*}} "-target=spir64_fpga" "-kind=sycl" "[[BUNDLEOUT]]"
155155
// CHK-FPGA-AOCX-SRC: llc{{.*}} "-filetype=obj" "-o" "[[LLCOUT:.+\.(o|obj)]]" "[[WRAPOUT]]"
156-
// CHK-FPGA-AOCX-SRC: llvm-link{{.*}} "-o" "[[LLVMLINKOUT:.+\.bc]]" "--suppress-warnings"
156+
// CHK-FPGA-AOCX-SRC: clang{{.*}} "-cc1" {{.*}} "-fsycl-is-device" {{.*}} "-o" "[[DEVICEBC:.+\.bc]]"
157+
// CHK-FPGA-AOCX-SRC: llvm-link{{.*}} "[[DEVICEBC]]" "-o" "[[LLVMLINKOUT:.+\.bc]]" "--suppress-warnings"
157158
// CHK-FPGA-AOCX-SRC: llvm-spirv{{.*}} "-o" "[[LLVMSPVOUT:.+\.spv]]" {{.*}} "[[LLVMLINKOUT]]"
158159
// CHK-FPGA-AOCX-SRC: clang-offload-wrapper{{.*}} "-o=[[WRAPOUTSRC:.+.bc]]" {{.*}} "-target=spir64_fpga" "-kind=sycl" "[[LLVMSPVOUT]]"
159160
// CHK-FPGA-AOCX-SRC: llc{{.*}} "-filetype=obj" "-o" "[[LLCOUTSRC:.+\.(o|obj)]]" "[[WRAPOUTSRC]]"

0 commit comments

Comments
 (0)