Skip to content

Commit

Permalink
[SYCL] Revert barrier deprecation note (#4162)
Browse files Browse the repository at this point in the history
New barrier is different from SYCL 1.2.1 and is known to cause
performance regressions on some configurations. Remove deprecation
notice from older barrier until the issue is sorted out.
  • Loading branch information
Alexander Batashev authored Jul 26, 2021
1 parent 6ac26ad commit 18c80fa
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
1 change: 0 additions & 1 deletion sycl/include/CL/sycl/nd_item.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,6 @@ template <int dimensions = 1> class nd_item {
get_offset());
}

__SYCL2020_DEPRECATED("use sycl::group_barrier() free function instead")
void barrier(access::fence_space accessSpace =
access::fence_space::global_and_local) const {
uint32_t flags = detail::getSPIRVMemorySemanticsMask(accessSpace);
Expand Down
2 changes: 0 additions & 2 deletions sycl/test/warnings/sycl_2020_deprecations.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -116,8 +116,6 @@ int main() {
CGH.parallel_for<class Test>(
sycl::nd_range<1>{sycl::range{10}, sycl::range{10}, sycl::range{1}},
[](sycl::nd_item<1> it) {
// expected-warning@+1{{'barrier' is deprecated: use sycl::group_barrier() free function instead}}
it.barrier();
// expected-warning@+2{{'mem_fence' is deprecated: use sycl::group_barrier() free function instead}}
// expected-warning@+1{{'mem_fence<sycl::access::mode::read_write>' is deprecated: use sycl::group_barrier() free function instead}}
it.mem_fence();
Expand Down

0 comments on commit 18c80fa

Please sign in to comment.