Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] [FPGA] Create latency control E2E emulator tests #596

Merged
merged 2 commits into from
Dec 15, 2021

Conversation

shuoniu-intel
Copy link

@shuoniu-intel shuoniu-intel commented Dec 2, 2021

Create E2E emulator tests for newly added latency control headers.

The corresponding SYCL PR: intel/llvm#5066

@shuoniu-intel
Copy link
Author

/verify with intel/llvm#5066

@romanovvlad
Copy link

@MrSidims @mlychkov Could you please reivew?

MrSidims
MrSidims previously approved these changes Dec 6, 2021
@shuoniu-intel
Copy link
Author

/verify with intel/llvm#5066

romanovvlad pushed a commit to intel/llvm that referenced this pull request Dec 8, 2021
…5066)

Create experimental header files that provide user API for
FPGA latency control feature.

experimental/fpga_lsu.hpp and experimental/pipes.hpp are
simply the original version plus latency control API
described in the extension documents.

experimental/fpga_utils.hpp provides utility functions used
by experimental LSU and pipe headers.
fpga_extensions.hpp will include new experimental LSU and
pipe headers.

Related PR for extension documents: #5027

Test: intel/llvm-test-suite#596
@shuoniu-intel
Copy link
Author

@romanovvlad Could you please review and merge?

@romanovvlad
Copy link

@romanovvlad Could you please review and merge?

I cannot merge, the pre-commit fails, maybe @vladimirlaz can help.

vladimirlaz
vladimirlaz previously approved these changes Dec 13, 2021
@vladimirlaz vladimirlaz self-requested a review December 13, 2021 15:46
@vladimirlaz
Copy link

vladimirlaz commented Dec 13, 2021

@romanovvlad your approve is needed to enable merge button. CI failure should not block merge.

Co-authored-by: Romanov Vlad <vlad.romanov@intel.com>
@vladimirlaz vladimirlaz merged commit b3dfd11 into intel:intel Dec 15, 2021
@shuoniu-intel shuoniu-intel deleted the latency-control-e2e branch December 15, 2021 17:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants