Skip to content
This repository was archived by the owner on Mar 28, 2023. It is now read-only.

[SYCL] Update tests for disabling fallback assert feature on FPGA device and disable Windows assert tests on CUDA #533

Merged
merged 10 commits into from
Dec 10, 2021

Conversation

s-kanaev
Copy link

@s-kanaev s-kanaev commented Oct 25, 2021

Tests update for intel/llvm#4780 and intel/llvm#4810

Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
vladimirlaz
vladimirlaz previously approved these changes Oct 25, 2021
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@bader
Copy link

bader commented Oct 25, 2021

I think it's worth to fix intel/llvm#4810 as well, while you are here.

Sergey Kanaev added 3 commits October 26, 2021 16:33
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@s-kanaev s-kanaev changed the title [SYCL] Update tests for disabling fallback assert feature on FPGA device [SYCL] Update tests for disabling fallback assert feature on FPGA device and disable Windows assert tests on CUDA Oct 26, 2021
Sergey Kanaev added 2 commits November 3, 2021 11:55
@s-kanaev s-kanaev force-pushed the disable-fb-assert-4-fpga branch from e3603e9 to 70470e5 Compare November 3, 2021 14:31
Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
@s-kanaev s-kanaev force-pushed the disable-fb-assert-4-fpga branch from 70470e5 to 831d8e9 Compare November 3, 2021 14:52
@s-kanaev
Copy link
Author

s-kanaev commented Dec 8, 2021

/verify with intel/llvm#4780

@s-kanaev s-kanaev requested review from vladimirlaz and bader December 8, 2021 12:02
@s-kanaev
Copy link
Author

s-kanaev commented Dec 8, 2021

@bader , @vladimirlaz , @romanovvlad , a friendly ping. The tests are running OK with appropriate changes in intel/llvm#4780.

bader
bader previously approved these changes Dec 9, 2021
Co-authored-by: Alexey Bader <alexey.bader@intel.com>
@s-kanaev s-kanaev dismissed stale reviews from bader via fe0ad57 December 9, 2021 11:08
@s-kanaev
Copy link
Author

s-kanaev commented Dec 9, 2021

/verify with intel/llvm#4780

@romanovvlad romanovvlad merged commit 74e49b3 into intel:intel Dec 10, 2021
aelovikov-intel pushed a commit to aelovikov-intel/llvm that referenced this pull request Mar 27, 2023
Disabling fallback assert feature on FPGA device and disable
Windows assert tests on CUDA 

Signed-off-by: Sergey Kanaev <sergey.kanaev@intel.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants