This repository was archived by the owner on Mar 28, 2023. It is now read-only.
[SYCL] Add a test checking wrapped USM pointers #1288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The big changes are being made to clang's handling of wrapped USM pointers. This simple test is to make sure that nothing breaks.
|
FYI, the first PR with redesign is here - intel/llvm#6728 . And more is coming... |
|
@KseniyaTikhomirova & @intel/llvm-reviewers-runtime , could you please review? |
KseniyaTikhomirova
approved these changes
Sep 26, 2022
v-klochkov
reviewed
Sep 26, 2022
Comment on lines
+41
to
+43
| NonTrivial NonTrivialObj(sycl::malloc_shared<int>(NumOfElements, Q), 38); | ||
| Simple SimpleObj = {sycl::malloc_shared<int>(NumOfElements, Q), 42}; | ||
| WrapperOfSimple WrapperOfSimpleObj = { |
There was a problem hiding this comment.
Please free the allocated memory at the end of the program.
There was a problem hiding this comment.
Done, thanks!
Apparently simple USM examples from SYCL 2020 spec do not free memory as well :)
v-klochkov
approved these changes
Sep 26, 2022
|
Some other test is failing in pre-commit: Failed Tests (1): |
|
@intel/llvm-gatekeepers , can this one be merged? |
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
* [SYCL] Add a test checking wrapped USM pointers The big changes are being made to clang's handling of wrapped USM pointers. This simple test is to make sure that nothing breaks.
myler
pushed a commit
to myler/llvm-test-suite
that referenced
this pull request
Mar 22, 2023
…#1288) Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
aelovikov-intel
pushed a commit
to aelovikov-intel/llvm
that referenced
this pull request
Mar 27, 2023
…e#1288) * [SYCL] Add a test checking wrapped USM pointers The big changes are being made to clang's handling of wrapped USM pointers. This simple test is to make sure that nothing breaks.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The big changes are being made to clang's handling of wrapped USM pointers. This simple test is to make sure that nothing breaks.