Skip to content

Fix aesmd service permission in linksgx.sh. #736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

yuguorui
Copy link
Contributor

Currently sgx-aesm-service does not depend on any other sgx packages, which makes it difficult to guarantee the installation order of sgx-aesm-service. Specifically, sgx-aesm-service may be installed earlier than libsgx-ae-pce, but the user group sgx_prv was created by the latter.

This PR ensures that no matter what the order of package installation is, aesmd can have access to the sgx_provision device file.

@fqiu1
Copy link
Contributor

fqiu1 commented Jul 27, 2021

It's legitimate to install sgx-aesm-service without creating sgx_prv group. For instance, some users might just want to load normal enclaves and don't want to use attestation.

@yuguorui
Copy link
Contributor Author

It's legitimate to install sgx-aesm-service without creating sgx_prv group. For instance, some users might just want to load normal enclaves and don't want to use attestation.

Yes, you are right in non-DCAP platform.
But for DCAP scenarios, which runs upon CPUs support FLC, I do not find a situation where aesmd-service needs to be installed without attestation.

Copy link
Contributor

@veehaitch veehaitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please avoid absolute paths to executables. This assumes the host system adheres to the Filesystem Hierarchy Standard which is not always the case (a notable exception is Nix). Also see #730.

@yuguorui
Copy link
Contributor Author

Please avoid absolute paths to executables. This assumes the host system adheres to the Filesystem Hierarchy Standard which is not always the case (a notable exception is Nix). Also see #730.

Sure, thanks for your comments.

I will push a new version later.

This commit ensures that no matter what the order of package installation is,
aesmd can have access to the sgx_provision device file.

Signed-off-by: yuguorui <yuguorui@pku.edu.cn>
@lzha101 lzha101 merged commit 71211ef into intel:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants