ptxed: fix potential error mixup

In the inner decoding loop, we use status to indicate errors and turn them
into -pte_internal in case we break out of the decode loop without an
error.

The only exception to this is obtaining the decoder offset, where we use
errcode.  If we ever had an error, there, it would get overwritten by
-pte_internal.

Fix it.

Signed-off-by: Markus Metzger <markus.t.metzger@intel.com>

Author: markus-metzger

ptxed/src/ptxed.c

@@ -1580,10 +1580,8 @@ static void decode_insn(struct ptxed_decoder *decoder,
 			}
 
 			if (options->print_offset || options->check) {
-				int errcode;
-
-				errcode = pt_insn_get_offset(ptdec, &offset);
-				if (errcode < 0)
+				status = pt_insn_get_offset(ptdec, &offset);
+				if (status < 0)
 					break;
 			}
 
@@ -1620,10 +1618,6 @@ static void decode_insn(struct ptxed_decoder *decoder,
 				check_insn(&insn, offset);
 		}
 
-		/* We shouldn't break out of the loop without an error. */
-		if (!status)
-			status = -pte_internal;
-
 		/* We're done when we reach the end of the trace stream. */
 		if (status == -pte_eos)
 			break;
@@ -1989,10 +1983,8 @@ static void decode_block(struct ptxed_decoder *decoder,
 			}
 
 			if (options->print_offset || options->check) {
-				int errcode;
-
-				errcode = pt_blk_get_offset(ptdec, &offset);
-				if (errcode < 0)
+				status = pt_blk_get_offset(ptdec, &offset);
+				if (status < 0)
 					break;
 			}
 
@@ -2032,10 +2024,6 @@ static void decode_block(struct ptxed_decoder *decoder,
 				check_block(&block, iscache, offset);
 		}
 
-		/* We shouldn't break out of the loop without an error. */
-		if (!status)
-			status = -pte_internal;
-
 		/* We're done when we reach the end of the trace stream. */
 		if (status == -pte_eos)
 			break;