-
Notifications
You must be signed in to change notification settings - Fork 68
Replace isF...() LLVM API calls with the corresponding isa<...>() #3268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why are you using a LLVM newer than the one specify in https://github.com/intel/intel-xpu-backend-for-triton/blob/main/cmake/llvm-hash.txt? |
I'm building with a custom version of LLVM. Anyway, this fix seem compatible with both versions and will also be required when bumping the LLVM version. |
Can you please upstream the changes in core files directly? |
Sure, I'll do. |
Done - triton-lang/triton#5713 |
Thanks, why is it a draft? |
Thanks, fixed. |
0938622
to
3a5bddf
Compare
The isF...() methods have been removed in the main LLVM branch: llvm/llvm-project#123326
3a5bddf
to
c489597
Compare
It has been fixed upstream triton-lang/triton#5684 |
The isF...() methods have been removed in the main LLVM branch: llvm/llvm-project#123326
Fixes #3269
New contributor declaration
I am not making a trivial change, such as fixing a typo in a comment.
I have written a PR description following these
rules.
I have run
pre-commit run --from-ref origin/main --to-ref HEAD
.Select one of the following.
/test
forlit
tests/unittest
for C++ tests/python/test
for end-to-end teststhis is a build fix
.Select one of the following.
lit
tests.lit
tests I have added follow these best practices,including the "tests should be minimal" section. (Usually running Python code
and using the instructions it generates is not minimal.)