Skip to content

Replace isF...() LLVM API calls with the corresponding isa<...>() #3268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

AndreyPavlenko
Copy link
Contributor

@AndreyPavlenko AndreyPavlenko commented Jan 26, 2025

The isF...() methods have been removed in the main LLVM branch: llvm/llvm-project#123326
Fixes #3269

New contributor declaration

  • I am not making a trivial change, such as fixing a typo in a comment.

  • I have written a PR description following these
    rules.

  • I have run pre-commit run --from-ref origin/main --to-ref HEAD.

  • Select one of the following.

    • I have added tests.
      • /test for lit tests
      • /unittest for C++ tests
      • /python/test for end-to-end tests
    • This PR does not need a test because this is a build fix.
  • Select one of the following.

    • I have not added any lit tests.
    • The lit tests I have added follow these best practices,
      including the "tests should be minimal" section. (Usually running Python code
      and using the instructions it generates is not minimal.)

@AndreyPavlenko AndreyPavlenko marked this pull request as ready for review January 26, 2025 13:19
@whitneywhtsang
Copy link
Contributor

Why are you using a LLVM newer than the one specify in https://github.com/intel/intel-xpu-backend-for-triton/blob/main/cmake/llvm-hash.txt?

@AndreyPavlenko
Copy link
Contributor Author

Why are you using a LLVM newer than the one specify in https://github.com/intel/intel-xpu-backend-for-triton/blob/main/cmake/llvm-hash.txt?

I'm building with a custom version of LLVM. Anyway, this fix seem compatible with both versions and will also be required when bumping the LLVM version.

@AndreyPavlenko AndreyPavlenko self-assigned this Jan 27, 2025
@whitneywhtsang
Copy link
Contributor

Can you please upstream the changes in core files directly?

@AndreyPavlenko
Copy link
Contributor Author

Can you please upstream the changes in core files directly?

Sure, I'll do.

@AndreyPavlenko
Copy link
Contributor Author

Can you please upstream the changes in core files directly?

Done - triton-lang/triton#5713

@whitneywhtsang
Copy link
Contributor

Can you please upstream the changes in core files directly?

Done - triton-lang/triton#5713

Thanks, why is it a draft?

@AndreyPavlenko
Copy link
Contributor Author

Thanks, why is it a draft?

Thanks, fixed.

@AndreyPavlenko
Copy link
Contributor Author

It has been fixed upstream triton-lang/triton#5684

@whitneywhtsang
Copy link
Contributor

The changes in this PR is merged in #3316, 4a99671.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails due to isF...() LLVM API calls
3 participants